Thanks Kevan. I can look into adding license headers to the files you listed below.

In talking of auto-generated files, I saw a couple of Java files have the following in the header -

/*
 * Auto-generated by J2G Migration.
 */

For example, all the java files in the j2g\trunk\src\main\resources\compatibility dir. The same 6 files also appear in the resources plugin source dir. Anyone has any idea how these files can be generated? Any reason why we are keeping the generated source files in svn?

Thanks

Lin


Kevan Miller wrote:

On Oct 8, 2007, at 3:19 PM, Donald Woods wrote:

Cool, thanks for doing this.

As soon as you're done with this JIRA, I'll create a branch for a 1.0.0 release....

I'd like to know how to build and run j2g...

There are no license/notice files, atm... Also, RAT is flagging the following files as not having apache src license headers (are the .classpath and .project files needed? or were they an accidental commit?) Any files that are non-trivial, non-machine generated, syntactically able to hold a comment, and created by our project should have a license header.

!????? ./configurator/.classpath
!????? ./configurator/.project
!????? ./plugins/org.apache.geronimo.devtools.j2g.common/.classpath
!????? ./plugins/org.apache.geronimo.devtools.j2g.common/.project
!????? ./plugins/org.apache.geronimo.devtools.j2g.common/META-INF/MANIFEST.MF
!????? ./plugins/org.apache.geronimo.devtools.j2g.descriptors/.classpath
!????? ./plugins/org.apache.geronimo.devtools.j2g.descriptors/.project
!????? ./plugins/org.apache.geronimo.devtools.j2g.descriptors/META-INF/MANIFEST.MF !????? ./plugins/org.apache.geronimo.devtools.j2g.descriptors/schema/tool.migrations.exsd !????? ./plugins/org.apache.geronimo.devtools.j2g.descriptors/test-resources/geronimo-application.xml !????? ./plugins/org.apache.geronimo.devtools.j2g.descriptors/test-resources/geronimo-web.xml !????? ./plugins/org.apache.geronimo.devtools.j2g.descriptors/test-resources/openejb-jar.xml
!????? ./plugins/org.apache.geronimo.devtools.j2g.jasper/.classpath
!????? ./plugins/org.apache.geronimo.devtools.j2g.jasper/.project
!????? ./plugins/org.apache.geronimo.devtools.j2g.jasper/META-INF/MANIFEST.MF
!????? ./plugins/org.apache.geronimo.devtools.j2g.resources/.classpath
!????? ./plugins/org.apache.geronimo.devtools.j2g.resources/.project
!????? ./plugins/org.apache.geronimo.devtools.j2g.resources/META-INF/MANIFEST.MF !????? ./plugins/org.apache.geronimo.devtools.j2g.resources/schema/tool.migrations.exsd !????? ./plugins/org.apache.geronimo.devtools.j2g.resources/test-apps/ds/hsqldb-geronimo-plan.xml !????? ./plugins/org.apache.geronimo.devtools.j2g.resources/test-apps/ds/mysql-geronimo-plan.xml !????? ./plugins/org.apache.geronimo.devtools.j2g.resources/test-apps/ds/oracle-geronimo-plan.xml !????? ./plugins/org.apache.geronimo.devtools.j2g.resources/test-apps/jms/jms-geronimo-plan.xml !????? ./plugins/org.apache.geronimo.devtools.j2g.resources/test-apps/mail/mail-geronimo-plan.xml !????? ./plugins/org.apache.geronimo.devtools.j2g.resources/test-apps/security/security-geronimo-plan.xml
!????? ./plugins/org.apache.geronimo.devtools.j2g.sources/.classpath
!????? ./plugins/org.apache.geronimo.devtools.j2g.sources/.project
!????? ./plugins/org.apache.geronimo.devtools.j2g.sources/META-INF/MANIFEST.MF !????? ./plugins/org.apache.geronimo.devtools.j2g.sources/schema/migrations.exsd
!????? ./plugins/org.apache.geronimo.devtools.j2g.util/.classpath
!????? ./plugins/org.apache.geronimo.devtools.j2g.util/.project
!????? ./plugins/org.apache.geronimo.devtools.j2g.util/META-INF/MANIFEST.MF
!????? ./plugins/org.apache.geronimo.devtools.j2g.util/test-apps/test-app-jboss/openejb-jar-serialized.xml

--kevan




Reply via email to