[
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537197
]
Ted Kirby commented on GERONIMODEVTOOLS-247:
--------------------------------------------
I see this is still in progress, but I did have a couple questions on the
changes you just checked in for this:
It seems that rev587700 is a lot of code (new org.apache.geronimo.st.v20.ui
plugin) for what looks above like just changing the groupId. There must be
more to it than that!
I think I recommend this patch:
Index: features/org.apache.geronimo.v20.feature/feature.xml
===================================================================
--- features/org.apache.geronimo.v20.feature/feature.xml (revision
587754)
+++ features/org.apache.geronimo.v20.feature/feature.xml (working copy)
@@ -39,15 +39,14 @@
<update label="Apache Geronimo Eclipse Update Site"
url="http://www.apache.org/dist/geronimo/eclipse/updates/"/>
</url>
+ <includes
+ id="org.apache.geronimo.v11.feature"
+ version="${org.apache.geronimo.v11.feature_version}"
+ name="Geronimo v1.1.x Server Adapter"/>
+
<requires>
<import feature="org.eclipse.jst" version="2.0.0" match="compatible"/>
- <import feature="org.apache.geronimo.feature"
version="${org.apache.geronimo.feature_version}"/>
- <import feature="org.apache.geronimo.v11.feature"
version="${org.apache.geronimo.v11.feature_version}"/>
</requires>
-
- <includes
- id="org.apache.geronimo.v11.feature"
- version="${org.apache.geronimo.v11.feature_version}"/>
<plugin
id="org.apache.geronimo.st.v20.core"
@@ -68,19 +67,5 @@
download-size="0"
install-size="0"
version="${version}"/>
-
- <plugin
- id="org.apache.geronimo.v11.deployment.model"
- download-size="0"
- install-size="0"
- version="${version}"
- unpack="false"/>
-
- <plugin
- id="org.apache.geronimo.v11.deployment.model.edit"
- download-size="0"
- install-size="0"
- version="${version}"
- unpack="false"/>
</feature>
I now recall not being clear on the v20 dependency on v11. if v20 includes
v11, it seems that the v11.deployment plugins should not be required in the v20
feature.xml.
On the other hand, if we can just include those two plugins, and not have to
include the whole v11 feature, that seems good!
> SharedLib dependency incorrectly generated for 2.0.x version of the Geronimo
> server
> -----------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-247
> URL:
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-247
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.0.0
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 2.0.2
>
>
> The SharedLib dependency is getting created as below in the web.xml, which is
> the old 1.1.1 format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>geronimo</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
> It should be as below for the 2.0.x format:
> <sys:dependencies>
> <sys:dependency>
> <sys:groupId>org.apache.geronimo.configs</sys:groupId>
> <sys:artifactId>sharedlib</sys:artifactId>
> <sys:type>car</sys:type>
> </sys:dependency>
> </sys:dependencies>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
