[
https://issues.apache.org/jira/browse/GERONIMO-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539684
]
Jarek Gawor commented on GERONIMO-3573:
---------------------------------------
Viet,
A few comments:
1) SnapshotProcessor does not need to extend Thread
2) "org.openejb.client.RemoteInitialContextFactory" should be
"org.apache.openejb.client.RemoteInitialContextFactory"
3) Start using Commons Logging API instead of outputting stuff to System.out or
doing e.printStackTrace()
> monitoring plugin: collecting agent's EJB should not be spawning and
> monitoring a thread
> ----------------------------------------------------------------------------------------
>
> Key: GERONIMO-3573
> URL: https://issues.apache.org/jira/browse/GERONIMO-3573
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3573.patch
>
>
> The collecting agent is spawning and monitoring a thread. It does this in
> order to periodically capture snapshots of the server's status. However,
> Anita pointed out that it is a violation of the EJB spec. And I have
> confirmed this. An alternative is to use EJB's TimerService.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
