[ 
https://issues.apache.org/jira/browse/GERONIMO-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581641#action_12581641
 ] 

Joseph Leong commented on GERONIMO-3887:
----------------------------------------

Further inspection has spawned the following approach:

The first approach was to ensure that the prereq description was correctly 
defined. 
However, the prereq description is not appropriate for preventing the 
installation of jetty plugins on tomcat containers and vise versa.  Reason 
being we want the flexibility to start with any framework and install a plugin 
of a certain container without explicitly instaling that container.

The second approach is to make the plugins more transactional.  That is if 
something were to go wrong, a complete rollback of the plugin install can be 
performed.  Factors to consider is that there will need to be a temporary copy 
of the original config state and a list of everything we put in the repo.  
However, the issue with this is that we aren't currently preserving the 
original state of the config files.. and often times the specific files are in 
the implementation details and not a general set.

Lastly, and the strongest approach that i am learning towards, is creating 
something on a higher layer.  Keep in mind this solution will help solve the 
issue in the administrative console but, will have to be dealt with seperately 
if it occurs in say.. GShell.  This feature in the admin console would hide 
plugins that match a certain regex.. say.. if we're in a Tomcat deployment.. 
hides or disables the Jetty options. 

In conclusion there is no good constraint implementation curretly in place.  
Please feel free to review the three options above and certainly contribute any 
ideas you my have.  I plan to implement the third one as of now.. 

Progress will be posted.

Thanks!

-Joseph Leong


> After installing with wrong configuration unable to proceed with any new 
> plugin installs
> ----------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3887
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3887
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.2
>            Reporter: Joseph Leong
>            Assignee: Joseph Leong
>             Fix For: 2.1.1, 2.2
>
>
> The plugin installer located in the administration console fails to install 
> new plugins once it runs into an install that throws an exception for being 
> the wrong configuration type.  IE. trying to install a Jetty piece on Tomcat.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to