[ 
https://issues.apache.org/jira/browse/GERONIMO-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600611#action_12600611
 ] 

Jason Warner commented on GERONIMO-4087:
----------------------------------------

The messages that are being shown are log messages.  The exception they are 
taken from seems to be caught and handled appropriately by the gshell interface 
already.  The code that results in this message being logged is 

{noformat}
        } catch (IOException e) {
            log.fatal("caught ", e);
            DeploymentManagerCreationException 
deploymentManagerCreationException = 
                    (DeploymentManagerCreationException) new 
DeploymentManagerCreationException(e.getMessage()).initCause(e);
            log.fatal("throwing ", deploymentManagerCreationException);
            throw deploymentManagerCreationException;
{noformat}

I suggest we change the log level to debug for these and wrap them in an if 
statement.  I'm not sure why they were set to fatal (log.error in trunk) and 
don't want to make the change without some other input.  Thoughts?

> Improve usability of gshell commands deploy/* when failing to connect to 
> server
> -------------------------------------------------------------------------------
>
>                 Key: GERONIMO-4087
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4087
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: commands
>    Affects Versions: 2.1.2
>            Reporter: YunFeng Ma
>            Assignee: Jason Warner
>            Priority: Minor
>             Fix For: 2.1.2, 2.1.x
>
>
> Run the below gshell commands when the server is stopped
>    > deploy/list-modules 
> It should output a message saying something like "Connection refused" instead 
> of the following exceptions:
> {noformat}
> 19:24:42,578 FATAL [BaseDeploymentFactory] caught
> java.io.IOException: Failed to retrieve RMIServer stub: 
> javax.naming.ServiceUnav
> ailableException [Root exception is java.rmi.ConnectException: Connection 
> refuse
> d to host: localhost; nested exception is:
>         java.net.ConnectException: Connection refused: connect]
>         at 
> javax.management.remote.rmi.RMIConnector.connect(RMIConnector.java:33
> 2)
>         at 
> javax.management.remote.JMXConnectorFactory.connect(JMXConnectorFacto
> ry.java:263)
>         at 
> org.apache.geronimo.deployment.plugin.factories.BaseDeploymentFactory
> .newRemoteDeploymentManager(BaseDeploymentFactory.java:173)
>         at 
> org.apache.geronimo.deployment.plugin.factories.BaseDeploymentFactory
> .getDeploymentManager(BaseDeploymentFactory.java:137)
>         at 
> javax.enterprise.deploy.shared.factories.DeploymentFactoryManager.get
> DeploymentManager(DeploymentFactoryManager.java:111)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.tryToConnect(Serv
> erConnection.java:186)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.doAuthPromptAndRe
> try(ServerConnection.java:240)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.tryToConnect(Serv
> erConnection.java:182)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.<init>(ServerConn
> ection.java:94)
>         at 
> org.apache.geronimo.deployment.cli.DeployTool.execute(DeployTool.java
> :161)
>         at 
> org.apache.geronimo.kernel.util.MainConfigurationBootstrapper.main(Ma
> inConfigurationBootstrapper.java:45)
>         at 
> org.apache.geronimo.cli.AbstractCLI.executeMain(AbstractCLI.java:67)
>         at 
> org.apache.geronimo.cli.deployer.DeployerCLI.main(DeployerCLI.java:31
> )
> Caused by:
> javax.naming.ServiceUnavailableException [Root exception is 
> java.rmi.ConnectExce
> ption: Connection refused to host: localhost; nested exception is:
>         java.net.ConnectException: Connection refused: connect]
>         at 
> com.sun.jndi.rmi.registry.RegistryContext.lookup(RegistryContext.java
> :112)
>         at 
> com.sun.jndi.toolkit.url.GenericURLContext.lookup(GenericURLContext.j
> ava:200)
>         at javax.naming.InitialContext.lookup(InitialContext.java:363)
>         at 
> javax.management.remote.rmi.RMIConnector.findRMIServerJNDI(RMIConnect
> or.java:1822)
>         at 
> javax.management.remote.rmi.RMIConnector.findRMIServer(RMIConnector.j
> ava:1792)
>         at 
> javax.management.remote.rmi.RMIConnector.connect(RMIConnector.java:27
> 4)
>         ... 12 more
> Caused by:
> java.rmi.ConnectException: Connection refused to host: localhost; nested 
> excepti
> on is:
>         java.net.ConnectException: Connection refused: connect
>         at sun.rmi.transport.tcp.TCPEndpoint.newSocket(TCPEndpoint.java:590)
>         at 
> sun.rmi.transport.tcp.TCPChannel.createConnection(TCPChannel.java:204
> )
>         at sun.rmi.transport.tcp.TCPChannel.newConnection(TCPChannel.java:190)
>         at sun.rmi.server.UnicastRef.newCall(UnicastRef.java:321)
>         at 
> sun.rmi.registry.RegistryImpl_Stub.lookup(RegistryImpl_Stub.java:88)
>         at 
> com.sun.jndi.rmi.registry.RegistryContext.lookup(RegistryContext.java
> :108)
>         ... 17 more
> Caused by:
> java.net.ConnectException: Connection refused: connect
>         at java.net.PlainSocketImpl.socketConnect(Native Method)
>         at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:372)
>         at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:233)
>         at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:220)
>         at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:385)
>         at java.net.Socket.connect(Socket.java:541)
>         at java.net.Socket.connect(Socket.java:491)
>         at java.net.Socket.<init>(Socket.java:399)
>         at java.net.Socket.<init>(Socket.java:208)
>         at 
> sun.rmi.transport.proxy.RMIDirectSocketFactory.createSocket(RMIDirect
> SocketFactory.java:41)
>         at 
> sun.rmi.transport.proxy.RMIMasterSocketFactory.createSocket(RMIMaster
> SocketFactory.java:145)
>         at sun.rmi.transport.tcp.TCPEndpoint.newSocket(TCPEndpoint.java:585)
>         ... 22 more
> 19:24:42,625 FATAL [BaseDeploymentFactory] throwing
> javax.enterprise.deploy.spi.exceptions.DeploymentManagerCreationException: 
> Faile
> d to retrieve RMIServer stub: javax.naming.ServiceUnavailableException [Root 
> exc
> eption is java.rmi.ConnectException: Connection refused to host: localhost; 
> nest
> ed exception is:
>         java.net.ConnectException: Connection refused: connect]
>         at 
> org.apache.geronimo.deployment.plugin.factories.BaseDeploymentFactory
> .newRemoteDeploymentManager(BaseDeploymentFactory.java:182)
>         at 
> org.apache.geronimo.deployment.plugin.factories.BaseDeploymentFactory
> .getDeploymentManager(BaseDeploymentFactory.java:137)
>         at 
> javax.enterprise.deploy.shared.factories.DeploymentFactoryManager.get
> DeploymentManager(DeploymentFactoryManager.java:111)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.tryToConnect(Serv
> erConnection.java:186)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.doAuthPromptAndRe
> try(ServerConnection.java:240)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.tryToConnect(Serv
> erConnection.java:182)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.<init>(ServerConn
> ection.java:94)
>         at 
> org.apache.geronimo.deployment.cli.DeployTool.execute(DeployTool.java
> :161)
>         at 
> org.apache.geronimo.kernel.util.MainConfigurationBootstrapper.main(Ma
> inConfigurationBootstrapper.java:45)
>         at 
> org.apache.geronimo.cli.AbstractCLI.executeMain(AbstractCLI.java:67)
>         at 
> org.apache.geronimo.cli.deployer.DeployerCLI.main(DeployerCLI.java:31
> )
> Caused by:
> java.io.IOException: Failed to retrieve RMIServer stub: 
> javax.naming.ServiceUnav
> ailableException [Root exception is java.rmi.ConnectException: Connection 
> refuse
> d to host: localhost; nested exception is:
>         java.net.ConnectException: Connection refused: connect]
>         at 
> javax.management.remote.rmi.RMIConnector.connect(RMIConnector.java:33
> 2)
>         at 
> javax.management.remote.JMXConnectorFactory.connect(JMXConnectorFacto
> ry.java:263)
>         at 
> org.apache.geronimo.deployment.plugin.factories.BaseDeploymentFactory
> .newRemoteDeploymentManager(BaseDeploymentFactory.java:173)
>         ... 10 more
> Caused by:
> javax.naming.ServiceUnavailableException [Root exception is 
> java.rmi.ConnectExce
> ption: Connection refused to host: localhost; nested exception is:
>         java.net.ConnectException: Connection refused: connect]
>         at 
> com.sun.jndi.rmi.registry.RegistryContext.lookup(RegistryContext.java
> :112)
>         at 
> com.sun.jndi.toolkit.url.GenericURLContext.lookup(GenericURLContext.j
> ava:200)
>         at javax.naming.InitialContext.lookup(InitialContext.java:363)
>         at 
> javax.management.remote.rmi.RMIConnector.findRMIServerJNDI(RMIConnect
> or.java:1822)
>         at 
> javax.management.remote.rmi.RMIConnector.findRMIServer(RMIConnector.j
> ava:1792)
>         at 
> javax.management.remote.rmi.RMIConnector.connect(RMIConnector.java:27
> 4)
>         ... 12 more
> Caused by:
> java.rmi.ConnectException: Connection refused to host: localhost; nested 
> excepti
> on is:
>         java.net.ConnectException: Connection refused: connect
>         at sun.rmi.transport.tcp.TCPEndpoint.newSocket(TCPEndpoint.java:590)
>         at 
> sun.rmi.transport.tcp.TCPChannel.createConnection(TCPChannel.java:204
> )
>         at sun.rmi.transport.tcp.TCPChannel.newConnection(TCPChannel.java:190)
>         at sun.rmi.server.UnicastRef.newCall(UnicastRef.java:321)
>         at 
> sun.rmi.registry.RegistryImpl_Stub.lookup(RegistryImpl_Stub.java:88)
>         at 
> com.sun.jndi.rmi.registry.RegistryContext.lookup(RegistryContext.java
> :108)
>         ... 17 more
> Caused by:
> java.net.ConnectException: Connection refused: connect
>         at java.net.PlainSocketImpl.socketConnect(Native Method)
>         at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:372)
>         at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:233)
>         at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:220)
>         at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:385)
>         at java.net.Socket.connect(Socket.java:541)
>         at java.net.Socket.connect(Socket.java:491)
>         at java.net.Socket.<init>(Socket.java:399)
>         at java.net.Socket.<init>(Socket.java:208)
>         at 
> sun.rmi.transport.proxy.RMIDirectSocketFactory.createSocket(RMIDirect
> SocketFactory.java:41)
>         at 
> sun.rmi.transport.proxy.RMIMasterSocketFactory.createSocket(RMIMaster
> SocketFactory.java:145)
>         at sun.rmi.transport.tcp.TCPEndpoint.newSocket(TCPEndpoint.java:585)
>         ... 22 more
>     Error: Unable to connect to server at deployer:geronimo:jmx://:1123
>     -- Failed to retrieve RMIServer stub:
>     javax.naming.ServiceUnavailableException [Root exception is
>     java.rmi.ConnectException: Connection refused to host: localhost;
>     nested exception is:
>         java.net.ConnectException: Connection refused: connect]
> javax.enterprise.deploy.spi.exceptions.DeploymentManagerCreationException: 
> Faile
> d to retrieve RMIServer stub: javax.naming.ServiceUnavailableException [Root 
> exc
> eption is java.rmi.ConnectException: Connection refused to host: localhost; 
> nest
> ed exception is:
>         java.net.ConnectException: Connection refused: connect]
>         at 
> org.apache.geronimo.deployment.plugin.factories.BaseDeploymentFactory
> .newRemoteDeploymentManager(BaseDeploymentFactory.java:182)
>         at 
> org.apache.geronimo.deployment.plugin.factories.BaseDeploymentFactory
> .getDeploymentManager(BaseDeploymentFactory.java:137)
>         at 
> javax.enterprise.deploy.shared.factories.DeploymentFactoryManager.get
> DeploymentManager(DeploymentFactoryManager.java:111)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.tryToConnect(Serv
> erConnection.java:186)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.doAuthPromptAndRe
> try(ServerConnection.java:240)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.tryToConnect(Serv
> erConnection.java:182)
>         at 
> org.apache.geronimo.deployment.cli.ServerConnection.<init>(ServerConn
> ection.java:94)
>         at 
> org.apache.geronimo.deployment.cli.DeployTool.execute(DeployTool.java
> :161)
>         at 
> org.apache.geronimo.kernel.util.MainConfigurationBootstrapper.main(Ma
> inConfigurationBootstrapper.java:45)
>         at 
> org.apache.geronimo.cli.AbstractCLI.executeMain(AbstractCLI.java:67)
>         at 
> org.apache.geronimo.cli.deployer.DeployerCLI.main(DeployerCLI.java:31
> )
> Caused by: java.io.IOException: Failed to retrieve RMIServer stub: 
> javax.naming.
> ServiceUnavailableException [Root exception is java.rmi.ConnectException: 
> Connec
> tion refused to host: localhost; nested exception is:
>         java.net.ConnectException: Connection refused: connect]
>         at 
> javax.management.remote.rmi.RMIConnector.connect(RMIConnector.java:33
> 2)
>         at 
> javax.management.remote.JMXConnectorFactory.connect(JMXConnectorFacto
> ry.java:263)
>         at 
> org.apache.geronimo.deployment.plugin.factories.BaseDeploymentFactory
> .newRemoteDeploymentManager(BaseDeploymentFactory.java:173)
>         ... 10 more
> Caused by: javax.naming.ServiceUnavailableException [Root exception is 
> java.rmi.
> ConnectException: Connection refused to host: localhost; nested exception is:
>         java.net.ConnectException: Connection refused: connect]
>         at 
> com.sun.jndi.rmi.registry.RegistryContext.lookup(RegistryContext.java
> :112)
>         at 
> com.sun.jndi.toolkit.url.GenericURLContext.lookup(GenericURLContext.j
> ava:200)
>         at javax.naming.InitialContext.lookup(InitialContext.java:363)
>         at 
> javax.management.remote.rmi.RMIConnector.findRMIServerJNDI(RMIConnect
> or.java:1822)
>         at 
> javax.management.remote.rmi.RMIConnector.findRMIServer(RMIConnector.j
> ava:1792)
>         at 
> javax.management.remote.rmi.RMIConnector.connect(RMIConnector.java:27
> 4)
>         ... 12 more
> Caused by: java.rmi.ConnectException: Connection refused to host: localhost; 
> nes
> ted exception is:
>         java.net.ConnectException: Connection refused: connect
>         at sun.rmi.transport.tcp.TCPEndpoint.newSocket(TCPEndpoint.java:590)
>         at 
> sun.rmi.transport.tcp.TCPChannel.createConnection(TCPChannel.java:204
> )
>         at sun.rmi.transport.tcp.TCPChannel.newConnection(TCPChannel.java:190)
>         at sun.rmi.server.UnicastRef.newCall(UnicastRef.java:321)
>         at 
> sun.rmi.registry.RegistryImpl_Stub.lookup(RegistryImpl_Stub.java:88)
>         at 
> com.sun.jndi.rmi.registry.RegistryContext.lookup(RegistryContext.java
> :108)
>         ... 17 more
> Caused by: java.net.ConnectException: Connection refused: connect
>         at java.net.PlainSocketImpl.socketConnect(Native Method)
>         at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:372)
>         at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:233)
>         at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:220)
>         at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:385)
>         at java.net.Socket.connect(Socket.java:541)
>         at java.net.Socket.connect(Socket.java:491)
>         at java.net.Socket.<init>(Socket.java:399)
>         at java.net.Socket.<init>(Socket.java:208)
>         at 
> sun.rmi.transport.proxy.RMIDirectSocketFactory.createSocket(RMIDirect
> SocketFactory.java:41)
>         at 
> sun.rmi.transport.proxy.RMIMasterSocketFactory.createSocket(RMIMaster
> SocketFactory.java:145)
>         at sun.rmi.transport.tcp.TCPEndpoint.newSocket(TCPEndpoint.java:585)
>         ... 22 more
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to