That's a good point, Jarek. I guess I wasn't really thinking when I made the change. As is, the logging is redundant. I'll make your suggested change shortly.
Thanks! On Thu, May 29, 2008 at 11:09 AM, Jarek Gawor <[EMAIL PROTECTED]> wrote: > Since the DeploymentManagerCreationException (or > AuthenticationFailedException) is initialized with .initCause(e) of > the root exception why log the root exception and the new exception? > Logging of DeploymentManagerCreationException or > AuthenticationFailedException should be enough (which will include the > root exception). > > Jarek > > On Thu, May 29, 2008 at 10:59 AM, <[EMAIL PROTECTED]> wrote: > > Author: jawarner > > Date: Thu May 29 07:59:43 2008 > > New Revision: 661343 > > > > URL: http://svn.apache.org/viewvc?rev=661343&view=rev > > Log: > > GERONIMO-4087: Improve usability of gshell commands deploy/* when failing > to connect to server > > > > Modified: > > > > geronimo/server/branches/2.1/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java > > > > Modified: > geronimo/server/branches/2.1/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java > > URL: > http://svn.apache.org/viewvc/geronimo/server/branches/2.1/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java?rev=661343&r1=661342&r2=661343&view=diff > > > ============================================================================== > > --- > geronimo/server/branches/2.1/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java > (original) > > +++ > geronimo/server/branches/2.1/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java > Thu May 29 07:59:43 2008 > > @@ -178,10 +178,14 @@ > > } > > return manager; > > } catch (IOException e) { > > - log.fatal("caught ", e); > > + if (log.isDebugEnabled()) { > > + log.debug("caught ", e); > > + } > > DeploymentManagerCreationException > deploymentManagerCreationException = > > (DeploymentManagerCreationException) new > DeploymentManagerCreationException(e.getMessage()).initCause(e); > > - log.fatal("throwing ", deploymentManagerCreationException); > > + if (log.isDebugEnabled()) { > > + log.debug("throwing ", > deploymentManagerCreationException); > > + } > > throw deploymentManagerCreationException; > > } catch (SecurityException e) { > > if (log.isDebugEnabled()) { > > > > > > > -- ~Jason Warner
