Hi Sainath, thanks very much for working on this. I'll review your patch later today or tomorrow...

Sainath Chowdary wrote:
Hi,

I completed the part of obtaining metadata complete information from Deployment Descriptors of Web Projects. I have attached a patch to the following JIRA for the same.
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-441

The new deployment descriptor classes are designed in such a way that it can be easily extended for other types of deployment descriptors. "AbstractDeploymentDescriptor" which is the parent for all other types stores the metadata complete descriptor as "Object" type. As J2EE and JavaEE webapp's are two totally complete unrelated classes (atleast according to eclipse jst implementation), I created a interface in our case "WebDeploymentDescriptor" which will be implemented by both J2EE and JavaEE descriptor. So,Our future classes for EJBs can extend AbstractDeploymentDescriptor and implement a EjbDeploymentDescriptor which would be common for both J2EE and JavaEE EJB types.

Also a utility class is created which returns the abstract deployment descriptor object properly initialized based on the type of project. Any feedback or comments?

On Tue, Jul 15, 2008 at 11:44 AM, Sainath Chowdary <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> wrote:

    I very much agree with YunFeng that we should provide a mechanism to
    link deployment plan and deployment descriptor. Even at present the
    GEP deployment plan wizards are not able to get information from
    deployment descriptor (like security roles, ejb-ref, resource-ref
    etc) or when respective annotations are used in the source files.

    I am currently working on the issue of having GEP Deployment Plan
    get the necessary information from web.xml or annotations. I believe
    that once we are able to retrieve necessary information from
    deployment desciptor, we can easily extend the approach to add also.



    On Tue, Jul 15, 2008 at 8:52 AM, YunFeng Ma <[EMAIL PROTECTED]
    <mailto:[EMAIL PROTECTED]>> wrote:

        Now the GEP provides rich funnctionalities to edit geronimo
        deployment plan, such as geronimo-web.xml, but it doesn't link
        deployment plan and deployment descriptor. For example, adding a
        EJB reference in the geronimo-web.xml Deployment editor only
        changes deployment plan,  it doesn't add a ejb-ref to deployment
        descriptor web.xml, the developers have to add the ejb-ref to
        web.xml manually.
        There are other such kind of pairs:  openejb-jar.xml vs.
        ejb-jar.xml, geronio-application.xml vs. application.xml,
geronimo-ra.xml vs. ra.xml etc. Most importantly, the design of GEP has not provided a mechanism
        to support this feature. I think we should consider this now
        rather than later when GEP becomes more complicated. What's your
        thought?

        Thanks
        -- Yun Feng




-- Thanks,
    Sainath Chowdary
    B.Tech III yr, Spring Semester
    Electronics & Communication Engg
    Indian Institute of Technology Roorkee




--
Thanks,
Sainath Chowdary
B.Tech III yr, Spring Semester
Electronics & Communication Engg
Indian Institute of Technology Roorkee

--
Thanks,
Tim McConnell

Reply via email to