[
https://issues.apache.org/jira/browse/GERONIMO-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660642#action_12660642
]
super-creek edited comment on GERONIMO-4474 at 1/4/09 3:51 PM:
-------------------------------------------------------------
Gang,
We found a patch defect during working GERONIMO-4485 issue.
it is viewJMXServer.jsp in jsp-localization-debugview.patch:
{code}
@@ -965,13 +967,13 @@
width="100%">
<thead>
<tr>
- <th field="Name" dataType="String"
width="10%"> Name </th>
- <th dataType="html"
width="20%"> Value </th>
- <th field="Type" dataType="String"
width="10%"> Type </th>
- <th field="Getter" dataType="String"
width="10%"> Getter </th>
- <th dataType="html"
width="10%"> Setter </th>
- <th field="Manageable" dataType="String"
width="10%" align="center"> Manageable </th>
- <th field="Persistent" dataType="String"
width="10%" align="center"> Persistent </th>
+ <th field="Name" dataType="String"
width="10%"> <fmt:message key="jmxmanager.help.name"/> </th>
+ <th dataType="html" width="20%"> <fmt:message
key="jmxmanager.help.value"/> </th>
+ <th field="Type" dataType="String"
width="10%"> <fmt:message key="jmxmanager.help.type"/> </th>
+ <th field="Getter" dataType="String"
width="10%"> <fmt:message key="jmxmanager.help.getter"/> </th>
+ <th dataType="html" width="10%"> <fmt:message
key="jmxmanager.help.server"/> </th> --> Here!!!
+ <th field="Manageable" dataType="String"
width="10%" align="center"> <fmt:message
key="jmxmanager.help.manageable"/> </th>
+ <th field="Persistent" dataType="String"
width="10%" align="center"> <fmt:message
key="jmxmanager.help.persistent"/> </th>
<!--
<th field="Readable" dataType="String"
width="10%"> Readable </th>
<th field="Writable" dataType="String"
width="10%"> Writable </th>
@@ -984,7 +986,7 @@
{code}
the debugview console shows not "Setter" but "Server". this is wrong.
Please re-fix it immediately.
was (Author: super-creek):
Gang,
We found a patch defect during working GERONIMO-4485 issue.
it is viewJMXServer.jsp in jsp-localization-debugview.patch:
{code}
- <th dataType="html" width="10%"> Setter </th>
+ <th dataType="html" width="10%"> <fmt:message
key="jmxmanager.help.server"/> </th>
{code}
the debugview console shows not "Setter" but "Server". this is wrong.
Please re-fix it immediately.
> Pull out the text in the JSP files to resource bundle files
> -----------------------------------------------------------
>
> Key: GERONIMO-4474
> URL: https://issues.apache.org/jira/browse/GERONIMO-4474
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.2
> Reporter: Ivan
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.2
>
> Attachments: jsp-localization-activemq.patch,
> jsp-localization-console.patch, jsp-localization-debugview.patch,
> jsp-localization-monitoring.patch, jsp-localization-openejb.patch,
> jsp-localization-plancreator.patch, jsp-localization-plancreator_v2.patch,
> jsp-localization-plugin.patch, jsp-localization-sysdb.patch
>
>
> Currently in the admin console, some text are hard coded in the JSP files.
> We need to pull them out to the resource bundle files, so that we could
> deliver multi-language versions in the future.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
