[
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
B.J. Reed closed GERONIMODEVTOOLS-547.
--------------------------------------
Resolution: Fixed
Fixed in r733105 in 2.1.4 and r733106 in trunk. Thanks to Delos Dai for the
patch, the code within GeronimoServerPluginManager.java has been greatly
reduced and org.apache.geronimo.system.plugin.PluginInstaller is now being
used..
I couldn't reproduce the exception you were getting. When I tried to match up
the exception output with the code, it didn't match, so it may be that
something funny was going on. Maybe try a fresh trunk build and see if you
still have the problem. If so, open a new JIRA for it. Thanks again.
> code cleanup on Server Plugin Manager
> -------------------------------------
>
> Key: GERONIMODEVTOOLS-547
> URL:
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547
> Project: Geronimo-Devtools
> Issue Type: Sub-task
> Components: eclipse-plugin
> Affects Versions: 2.2.0, 2.1.4
> Reporter: B.J. Reed
> Assignee: B.J. Reed
> Priority: Minor
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 547.patch, 547_updated.patch, 547_updated2.patch,
> exception.TXT
>
>
> From the initial version of the Server Plugin Manager, there are several
> things that can be streamlined.
> 1. use geronimo-system.jar file instead of the jaxbmodels
> (org.apache.geronimo.jee.plugin). When I tried to use the .jar file, I kept
> get exceptions that ObjectFactory could not be found. As it is now, the
> org.apache.geronimo.jee.plugin classes are exact duplicates of what is in the
> geronimo-system.jar file
> 2. GeronimoServerPluginManager.java should use PluginInstallerGbean. This
> will cut down on a lot of methods that were duplicated into this class.
> 3. Other methods in GeronimoServerPluginManager.java can probably make other
> calls to the jar files that we already are bringing into the GEP.
> All of this will make the code much slimmer and re-use a lot of good code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
