+1 ... with just one potential concern:
While not officially part of the binary distribution, I did notice that
the build/management scripts in the tag root source don't include the AL
header. I'm never sure just how paranoid we need to be about the AL
header for marginal parts like these. Given that these are only used to
create the image, I don't think it's a real concern (hence my +1).
However, I thought I should mention it just in case somebody has some
justification for why a header must be on those parts too. I personally
think it's probably safest just to add the header for the next release.
Joe
David Jencks wrote:
For various reasons we are now using a forked copy of tomcat derived
from the tomcat 6.0.20 release, built with maven, with maven
dependencies, etc etc.
The code changes from tomcat 6.0.20 are:
r814083 | djencks | 2009-09-11 16:36:16 -0700 (Fri, 11 Sep 2009) | 1 line
GERONIMO-4566 port fix for tomcats
https://issues.apache.org/bugzilla/show_bug.cgi?id=47378
------------------------------------------------------------------------
r799220 | xuhaihong | 2009-07-30 02:53:30 -0700 (Thu, 30 Jul 2009) | 1 line
GERONIMO-3451 "Restricted listeners property file not found" error
logged during Tomcat server startup (Patch from Shawn Jiang)
------------------------------------------------------------------------
r790767 | kevan | 2009-07-02 17:09:12 -0700 (Thu, 02 Jul 2009) | 1 line
GERONIMO-4685 Some customizations of Tomcat properties. Server info is
now: Apache Geronimo (Embedded Tomcat). Will want to merge in the future.
------------------------------------------------------------------------
r790765 | kevan | 2009-07-02 17:06:02 -0700 (Thu, 02 Jul 2009) | 1 line
GERONIMO-4685 Merge of 783305 from tomcat/tc6.0.x/trunk/. Fixes NPE in
MapperListener.registerHost(). I would expect that this fix would be in
6.0.22. So prolly won't require merging in the future
------------------------------------------------------------------------
r790742 | kevan | 2009-07-02 14:41:08 -0700 (Thu, 02 Jul 2009) | 1 line
GERONIMO-4685 Merge of Tomcat patches from 6.0.18 to 6.0.20. This
includes revision numbers 784303 and 784304. Does not include 787519,
which should already be in 6.0.20
------------------------------------------------------------------------
r790359 | gawor | 2009-07-01 13:23:00 -0700 (Wed, 01 Jul 2009) | 1 line
fill-in ServerInfo properties - but I can't add that to archetype as ant
task will fail
Staging repo:
https://repository.apache.org/content/repositories/geronimo-staging-023/
I forgot to include site generation stuff in the root pom before rolling
the release. I generated a site by applying rev 815573 to the checkout
used for the release build. The results are here:
http://people.apache.org/~djencks/staging-site/maven/external/tomcat-parent-6.0.20/6.0.20.0/
The structure is a little weird but I don't really want to spend time
fixing it up.
[ ] +1 go for it
[ ] 0
[ ] -1 whoa, hold on a minute
Vote open 72 hours
thanks
david jencks
