The risk is in the testsuite and docs, as some of the browser based tests have to specify the navigation path and/or portlet names. Making changes like this right before David is ready to start a release candidate is too risky in my book.

Also, the docs would need to be scrubbed to fix any console navigational guides to specific portlets.


-Donald


Shawn Jiang wrote:
This change is quite straightforward so that there's no risk from the technical perspective. IMO, If there's no non-tech objections, we should include it in new 22 release.

On Fri, Nov 20, 2009 at 1:09 PM, Rex Wang <[email protected] <mailto:[email protected]>> wrote:

    Hi Jeff,
    It is OK to me for 3.0
    but 2.2 is going to release. Looks like there is no time to do such
    changes..

    -Rex

    2009/11/20 chi runhua <[email protected] <mailto:[email protected]>>

        Hi devs,

        With the help of Shawn, we realized it's pretty easy to
        re-categorize the items in navigation pane because of flexible
        architecture of Geronimo plugin system. Just wonder if we could
        include the updates to the coming G2.2 release as a transitional
        stage of Console improvement task in G3.0. Here is how I did it.
Locate all the AdminConsoleExtensionGBean in plan.xml of each
        portlet and change the pageTitle attribute. For example,
              Update
                 <gbean name="JMSServerManager"
        class="org.apache.geronimo.pluto.AdminConsoleExtensionGBean">
                   <attribute name="pageTitle">Server/JMS Server</attribute>
                   ...
              To
                 <gbean name="JMSServerManager"
        class="org.apache.geronimo.pluto.AdminConsoleExtensionGBean">
                   <attribute name="pageTitle">Application Server/JMS
        Server</attribute>
                   ...
The new category is nearly identical with the proposal in
        https://issues.apache.org/jira/browse/GERONIMO-4950. I've built
        the server assembly locally and looks everything just works fine.

        If you think it's acceptable, I'll open a new JIRA and submit
        the patches for 2.2 branch&trunk later.

        Any comments?


        Jeff C





--
Shawn

Reply via email to