[ 
https://issues.apache.org/jira/browse/GERONIMO-4978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787311#action_12787311
 ] 

Nathan Beyer commented on GERONIMO-4978:
----------------------------------------

I'd like to create a test case for the FileCertificateRequestStore, but I'm not 
quite sure where to begin. If there are any similar test cases that I could 
compare it to, please let me know.

> [geronimo-security] FileCertificateRequestStore inappropriately uses 
> InputStream.available()
> --------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-4978
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4978
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: security
>    Affects Versions: 3.0
>            Reporter: Nathan Beyer
>         Attachments: geronimo-security-fcrs.patch
>
>
> The FileCertificateRequestStore.getRequest(String) method assumes that the 
> value returned by FileInputStream.available() is the entire length of the 
> stream. This is not guaranteed to be true.
> Additionally, the method constructs a String from a byte[] without defining a 
> character encoding, which means that the default encoding of the OS is used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to