[ 
https://issues.apache.org/jira/browse/GERONIMO-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896491#action_12896491
 ] 

Shawn Jiang commented on GERONIMO-5469:
---------------------------------------

Thanks Viola,  Some quick comments for the patch.

1, Some files are not in a well format.  There are a lot of tabs in the source 
code.  Some content looks not so good.  eg. ejb-multipoint\pom.xml
2, There are duplicate load.java in each clustering cases.  Could it be reused 
in some way ?
3, The overide-xml files are full config.xml instead of the snippet that 
matters to clustering setting. It's not so good for user to understand what's 
the key change for the setting.
4,  Could we doing config-substitution.properties  overrride in 
geronimo-maven-plugin ?

> Add EJB cluster testsuite
> -------------------------
>
>                 Key: GERONIMO-5469
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5469
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: testsuite
>    Affects Versions: 2.2.2
>            Reporter: viola.lu
>            Assignee: viola.lu
>            Priority: Minor
>             Fix For: 2.2.2
>
>         Attachments: G5469.patch
>
>
> 1.Create two servers with maven ant plugin which will copy servers from 
> geornimo tomcat javaee assemly and overridde config-subsitution.properties to 
> each server
> 2.Start two server instances , deploy loadbean to two servers, run ejb client 
> against two: failover:ejbd://127.0.0.1:4202,ejbd://127.0.0.1:4211"
> 3.Stop one server and run ejb client again. It still work, just on warning: 
> one server down. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to