Hi! +1 in general
@John, please also take a look at the ConfigJSR branch. It already contains many of the functionality already as Emily just copied over my changes from JSR-382 to mp-config. E.g all the implicit converters and array stuff is already done. Happy to have a hangout and do a pair review of it and then unify it again. LieGrue, strub > Am 24.12.2017 um 08:23 schrieb Romain Manni-Bucau <[email protected]>: > > Sounds good. Thanks for the heads up > > Le 24 déc. 2017 05:02, "John D. Ament" <[email protected]> a écrit : > Hey all > > I just pushed up the last of the changes in the Geronimo config trunk that > would align to the MP Config 1.2 spec. There's still a bit of clean up I > want to aim for, so maybe after the new year we can plan to cut a release of > Config 1.1? > > You'll note in my commit, I moved most of the logic around converter > registration from ConfigImpl into DefaultConfigBuilder. I think this works > out a bit better, this way we only have to register converters that are > prioritized. I want to align Implicit converters into the > MicroProfileTypedConverter class, to clean up the code a bit more. > > John
