[ 
https://issues.apache.org/jira/browse/GORA-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103973#comment-15103973
 ] 

ASF GitHub Bot commented on GORA-460:
-------------------------------------

GitHub user renato2099 opened a pull request:

    https://github.com/apache/gora/pull/52

    GORA-460

    Closing properties file before returning the file name.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/renato2099/gora GORA-460

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #52
    
----
commit 1518f80543300e8c64489f12bf6041fe995d843e
Author: Renato Marroquin <[email protected]>
Date:   2016-01-17T23:15:14Z

    GORA-460

----


> InputStream is not closed in DataStoreFactory#getMappingFile()
> --------------------------------------------------------------
>
>                 Key: GORA-460
>                 URL: https://issues.apache.org/jira/browse/GORA-460
>             Project: Apache Gora
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> Here is related code:
> {code}
>     InputStream mappingFile = 
> store.getClass().getClassLoader().getResourceAsStream(mappingFilename);
>     if (mappingFile == null)
>       throw new IOException("Unable to open mapping file: "+mappingFilename);
>     return mappingFilename;
> {code}
> mappingFile should be closed before returning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to