[
https://issues.apache.org/jira/browse/GORA-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104115#comment-15104115
]
ASF GitHub Bot commented on GORA-459:
-------------------------------------
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/51#issuecomment-172417218
+1
On Sunday, January 17, 2016, Renato Marroquin <[email protected]>
wrote:
> Fixing HBaseClusterSingleton.java unclosed resources returned from
> HBaseTestingUtility
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/gora/pull/51
> Commit Summary
>
> - GORA-459
>
> File Changes
>
> - *M*
>
gora-hbase/src/test/java/org/apache/gora/hbase/util/HBaseClusterSingleton.java
> <https://github.com/apache/gora/pull/51/files#diff-0> (7)
>
> Patch Links:
>
> - https://github.com/apache/gora/pull/51.patch
> - https://github.com/apache/gora/pull/51.diff
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/gora/pull/51>.
>
--
*Lewis*
> Resource leak due to unclosed Table
> -----------------------------------
>
> Key: GORA-459
> URL: https://issues.apache.org/jira/browse/GORA-459
> Project: Apache Gora
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> In HBaseClusterSingleton.java , there're several places where Table instance
> returned by HBaseTestingUtility methods (such as createTable) is not closed.
> Here is an example from ensureTable() :
> {code}
> if (!admin.tableExists(tableName)) {
> htu.createTable(tableName, cfs);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
