I was looking through the remaining PRs that are flagged for RC1:

https://github.com/apache/grails-core/pulls?q=is%3Aopen+is%3Apr+milestone%3Agrails%3A8.0.0-RC1

>From what I can tell there are a lot of RC1 related PRs, most with
only 1 reviewer.  The test ones & AI started ones I assume we can
skip, but I found a few issues that I think we should wait on the RC1
for:

1. https://github.com/apache/grails-core/pull/16044 - this identified
that the version of jansi we're using is the unsupported version,
while Groovy has switched to the supported one maintained by jline
2. https://github.com/apache/grails-core/pull/16052 - enum DDL - has
feedback that needs to be implemented
3. the configuration metadata PRs (2x)
4. https://github.com/apache/grails-core/pull/16040 - i think feedback
may have been implemented, but the tests hadn't yet run.
5. https://github.com/apache/grails-core/pull/16020 - the clob/text
issue that was reported for hibernate 7
6. https://github.com/apache/grails-core/pull/16028 - many join table
7. https://github.com/apache/grails-core/pull/16019 - Groovy Bean DSL
replacement

Other PRs that should probably be worked through:
1. https://github.com/apache/grails-core/pull/16025 - the AI
configuration (I think this has disagreements on the approach)
2.https://github.com/apache/grails-core/pull/15993 - logging
restructure of core classes (I haven't had time to review this one
yet)

My biggest concern is #1.  I did an initial pass at solving this one
and have PR opened (draft here:
https://github.com/apache/grails-core/pull/16078)  as a first step.
But it made me realize that as part of the CLI split, we never split
the tests - so dependencies are on the same classpath for tests.  I
think this is critical to fix, but I won't be able to get to it until
next week (unless someone else is willing?).

Further issues identified as part of this:
1. I think jline can be removed from the entire production classpath
with the cli split
2. some of the console specific classes did not get moved in the CLI
split (i.e. AnsiConsoleUrlMappingsRenderer)

I think we should hold on 8.0.0-RC1 to get through these tagged PR's
and solve the jansi issue before issuing an RC1.  What are people's
thoughts?

Reply via email to