On 22.04.2015 10:12, Stefan Sperling wrote: > On Wed, Apr 22, 2015 at 09:29:49AM +0200, Kaspar Brand wrote: >> Sorry for having missed this in my previous review: we should also >> #ifdef the SSL_RSSRC_EGD case in >> ssl_engine_config.c:ssl_cmd_SSLRandomSeed(), to make sure that "egd:..." >> settings are not silently ignored when mod_ssl is compiled against >> LibreSSL. Either let the failure then be detected by the >> ssl_util_path_check, or (probably better) reject it similar to how it's >> done for SSLCompression, SSLHonorCipherOrder etc. >> >> Kaspar > > Thanks, good catch. > > Is this fine?
Looks good to me, yes - thanks. Kaspar
