Am 16.09.26 um 16:55 schrieb Joe Orton:
On Wed, Sep 16, 2026 at 02:06:13PM +0200, Rainer Jung wrote:
Your code looks nice from visual inspection. I wonder, whether we should
really force "mod_mime_magic.c" to run before the new module via aszPre. If
we think it is the better module (in term of correctness) to decide on the
magic result, it should run before. But of course if we focus on
compatibility the new one should run after. Maybe we could drop
"mod_mime_magic.c" from aszPre. If only one of the two is loaded it doesn't
make a difference, if both are loaded it should be possible to define the
order by the LoadModule order.
I think it's good to have an order defined by the hooks rather than the
LoadModule order, but didn't think too hard about what that should be.
Given that mod_mime_libmagic is off by default it would make more sense
to flip the order and have libmagic run first (when enabled)?
+1
At least for Solaris Sparc (even 10) I know, that current "file" builds fine
(using a self-compiled latest gcc supporting that platform) and provides
pkgconfig info.
Great!
Regards, Joe
