On Fri, Sep 18, 2026 at 08:16:24AM +0000, Cornel Isbiceanu via dev wrote:
> Hi all,
> 
> Thank you for taking the time to look at this. I've applied all the 
> changes I had in mind and rebased the branch so it merges cleanly 
> against trunk. The PR is here:
> 
> https://github.com/apache/httpd/pull/750/changes
> 
> I'm very much open to any further changes — whether that's naming, the 
> directive's allowed context, the way the file is parsed, security 
> considerations, tests, or anything else the reviewers feel would make 
> it a better fit for httpd. Happy to iterate as much as needed; I'd 
> rather get it right than get it in.

Thanks for redoing it. Makes sense to me to restrict the directive like 
this. Does anybody else have any feedback/concerns here now?

> One small thing: I haven't seen any CI checks run on the PR yet.

Unfortunately due to the way our SVN->Git mirror is set up, we are not 
able to approve CI runs for non-committers. If you enable Actions in 
your fork it should run there, and I think the results becomes visible 
in the apache/httpd PR as well (not sure about that, but at least you 
could point to them). The fact you've added test cases which we can 
verify is more than sufficient in any case.

Regards, Joe

Reply via email to