hi Andy ziming comment is right. I will check your PR later
Best, Chia-Ping ziming deng <dengziming1...@gmail.com> 於 2025年5月21日 週三 上午10:22寫道： > I don’t have experience generating content for kafka.apache.org , but > according to the content of https://github.com/apache/kafka-site , I > guess it will be regenerated the next time the kafka-site repository is > updated, but I’m not sure about it. > > - > Ziming > > > On May 21, 2025, at 9:17 AM, Andy Li <a...@codecrafters.io> wrote: > > > > The PR was merged by Chia-Ping. > > > > Guys, do you know what's the next scheduled date when > > https://kafka.apache.org/protocol.html will be updated? Thanks! > > > > - Andy > > > > > > On Tue, 20 May 2025 at 11:44, Andy Li <a...@codecrafters.io> wrote: > > > >> PR opened: https://github.com/apache/kafka/pull/19769 Thanks! > >> > >> - Andy > >> > >> > >> On Tue, 20 May 2025 at 11:35, Ziming Deng <dengziming1...@gmail.com> > >> wrote: > >> > >>> Can you submit a PR to fix it? Thank you! > >>> > >>>> On May 20, 2025, at 11:26, Andy Li <a...@codecrafters.io> wrote: > >>>> > >>>> Hey Ziming, > >>>> > >>>> Thanks for pointing to org.apache.kafka.common.protocol.Protocal.main! > >>>> > >>>> It seem that this line should use `<=` instead `<`: > >>>> > >>>> Protocol.java < > >>> > https://github.com/apache/kafka/blob/cff10e654149ed2d4924235a15156d4bc0bf7b4a/clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java#L211 > >>>> > >>>> > >>>> > >>>> > >>>> - Andy > >>>> > >>>> > >>>> On Tue, 20 May 2025 at 10:38, Ziming Deng <dengziming1...@gmail.com > >>> <mailto:dengziming1...@gmail.com>> wrote: > >>>>> Hello Andi, > >>>>> This page content is generated from > >>> org.apache.kafka.common.protocol.Protocal.main , can you help to check > it? > >>>>> > >>>>>> On May 20, 2025, at 09:13, Andy Li <a...@codecrafters.io <mailto: > >>> a...@codecrafters.io>> wrote: > >>>>>> > >>>>>> Hi Kafka Team, > >>>>>> > >>>>>> I noticed a couple of response formats missing from the Kafka > >>> protocol guide > >>>>>> <https://kafka.apache.org/protocol.html#protocol_common>: > >>>>>> > >>>>>> - *ApiVersions Response (Version: 4)* — Only versions 0–3 are > >>> documented, > >>>>>> though version 4 of the request is included. > >>>>>> > >>>>>> - *DescribeTopicPartitions Response* — Not listed at all. > >>>>>> > >>>>>> - *Fetch Response (Version: 17)* — Only versions 4–16 are > documented, > >>>>>> though version 17 of the request is included. > >>>>>> > >>>>>> Just wanted to flag in case this was unintentional. Thanks for all > >>> the > >>>>>> great work on Kafka! > >>>>>> > >>>>>> Best, > >>>>>> > >>>>>> Andy Li > >>>>> > >>> > >>> > >
