Thanks for changes to the KIP; this looks good to me! Best, Jonah
On Tue, Jul 22, 2025 at 3:31 PM Mahsa Seifikar <mseifi...@confluent.io.invalid> wrote: > Hi Kevin, > > You're right. I wanted to change the formula format and forgot to switch it > back to the original formula, which should be `idle_time/total_time`. I've > updated KIP. > > Thanks, > Mahsa Seifikar > > On Tue, Jul 22, 2025 at 2:18 PM Kevin Wu <kevin.wu2...@gmail.com> wrote: > > > Hi Mahsa, > > > > I see you have the definition of the metric value as: > > controller idle ratio = idle_time/active_time > > > > Shouldn't the value for a ratio be: > > controller idle ratio = idle_time/total_time > > where total_time = idle_time + active_time? > > This lines up with the definition you outlined earlier in the metric > value > > description. > > > > Best, > > Kevin Wu > > > > On Tue, Jul 22, 2025 at 11:54 AM Mahsa Seifikar > > <mseifi...@confluent.io.invalid> wrote: > > > > > Thanks Jonah and Kevin for the feedback. > > > > > > I have updated the KIP accordingly. We ideally want to use something > like > > > the TimeRatio type for this metric, similar to how "poll-idle-ratio" is > > > measured in KafkaRaftMetrics. > > > > > > Please let me know if you have any further feedback. > > > > > > Best, > > > Mahsa Seifikar > > > > > > On Fri, Jul 11, 2025 at 4:08 PM Kevin Wu <kevin.wu2...@gmail.com> > wrote: > > > > > > > Hi Mahsa and Jonah, > > > > > > > > Since we're adding this new metric to a metrics group that is still > > using > > > > Yammer, ideally I think we want to use RatioGauge to give us the > > sampling > > > > functionality we need. It's possible that we can get similar > > > functionality > > > > from Histogram, which I know other Yammer metrics in Kafka use. We > are > > > > still able to get gauge metrics from the histogram, as they are the > > most > > > > straightforward for the operator to monitor (e.g. if the metric > value > > > > X, > > > > alert). For example, metrics that are histograms, like > > EventQueueTimeMs, > > > > are often monitored via their p99 or p999 value. > > > > > > > > There are several other "thread-idle-ratio" metrics in Kafka, but > those > > > are > > > > all using the newer, internal KafkaMetrics library's sensors. > > > > > > > > Best, > > > > Kevin Wu > > > > > > > > On Thu, Jul 10, 2025 at 2:09 PM Mahsa Seifikar > > > > <mseifi...@confluent.io.invalid> wrote: > > > > > > > > > Hi Jonah and Kevin, > > > > > > > > > > Thanks for your comments. I have now updated the KIP to address > your > > > > > feedback. > > > > > > > > > > Please let me know if you have any further questions. > > > > > > > > > > Best, > > > > > Mahsa Seifikar > > > > > > > > > > On Thu, Jul 3, 2025 at 4:40 PM Mahsa Seifikar < > > mseifi...@confluent.io> > > > > > wrote: > > > > > > > > > > > Hello all, > > > > > > > > > > > > I wrote a short KIP to add a new metric for controller thread > > > idleness. > > > > > > > > > > > > Here is the link: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1190%3A+Add+a+metric+for+controller+thread+idleness > > > > > > > > > > > > Thanks, > > > > > > Mahsa Seifikar > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
