svn commit: r177913 - /maven/components/trunk/maven-plugin-api/src/main/java/org/apache/maven/plugin /maven/components/trunk/maven-reports/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo

[brett]

Author: brett
Date: Sun May 22 20:57:28 2005
New Revision: 177913

URL: http://svn.apache.org/viewcvs?rev=177913&view=rev
Log:
implement some inspection settings
The EAP now uses these settings to show highlighting and intentions in the 
editor, which is really helpful.
Once happy with settings, I will publish them for others to use

Modified:
    
maven/components/trunk/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java
    
maven/components/trunk/maven-plugin-api/src/main/java/org/apache/maven/plugin/Mojo.java
    
maven/components/trunk/maven-reports/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ProjectReportsMojo.java

Modified: 
maven/components/trunk/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java
URL: 
http://svn.apache.org/viewcvs/maven/components/trunk/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java?rev=177913&r1=177912&r2=177913&view=diff
==============================================================================
--- 
maven/components/trunk/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java
 (original)
+++ 
maven/components/trunk/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java
 Sun May 22 20:57:28 2005
@@ -34,21 +34,11 @@
 
     public Log getLog()
     {
-        synchronized ( this )
+        if ( log == null )
         {
-            if ( log == null )
-            {
-                log = new SystemStreamLog();
-            }
+            log = new SystemStreamLog();
         }
 
         return log;
     }
-
-    public void execute()
-        throws MojoExecutionException
-    {
-        throw new MojoExecutionException( "You must override execute() if you 
implement the new paradigm" );
-    }
-
 }

Modified: 
maven/components/trunk/maven-plugin-api/src/main/java/org/apache/maven/plugin/Mojo.java
URL: 
http://svn.apache.org/viewcvs/maven/components/trunk/maven-plugin-api/src/main/java/org/apache/maven/plugin/Mojo.java?rev=177913&r1=177912&r2=177913&view=diff
==============================================================================
--- 
maven/components/trunk/maven-plugin-api/src/main/java/org/apache/maven/plugin/Mojo.java
 (original)
+++ 
maven/components/trunk/maven-plugin-api/src/main/java/org/apache/maven/plugin/Mojo.java
 Sun May 22 20:57:28 2005
@@ -31,4 +31,6 @@
 
     // TODO: not sure about this here, and may want a getLog on here as 
well/instead
     void setLog( Log log );
+
+    Log getLog();
 }

Modified: 
maven/components/trunk/maven-reports/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ProjectReportsMojo.java
URL: 
http://svn.apache.org/viewcvs/maven/components/trunk/maven-reports/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ProjectReportsMojo.java?rev=177913&r1=177912&r2=177913&view=diff
==============================================================================
--- 
maven/components/trunk/maven-reports/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ProjectReportsMojo.java
 (original)
+++ 
maven/components/trunk/maven-reports/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ProjectReportsMojo.java
 Sun May 22 20:57:28 2005
@@ -34,8 +34,8 @@
 import java.util.Map;
 
 /**
+ * A Maven2 plugin which generates the set of project reports.
  * @goal generate
- * @description A Maven2 plugin which generates the set of project reports
  *
  * @author <a href="mailto:[EMAIL PROTECTED]">Brett Porter</a>
  * @version $Id: ProjectReportsMojo.java,v 1.3 2005/02/23 00:08:03 brett Exp $
@@ -44,12 +44,6 @@
     extends AbstractMojo
 {
     /**
-     * @parameter expression="${basedir}"
-     * @required
-     */
-    private String basedir;
-
-    /**
      * @parameter expression="${basedir}/src/site"
      * @required
      */
@@ -134,6 +128,7 @@
         return buffer.toString();
     }
 
+    /** @noinspection IOResourceOpenedButNotSafelyClosed*/
     private InputStream getSiteDescriptor()
         throws MojoExecutionException
     {
@@ -144,7 +139,7 @@
             throw new MojoExecutionException( "The site descriptor is not 
present!" );
         }
 
-        String siteDescriptorContent = "";
+        String siteDescriptorContent;
 
         try
         {
@@ -155,7 +150,7 @@
             throw new MojoExecutionException( "The site descriptor cannot be 
read!", e );
         }
 
-        Map props = new HashMap();
+        Map props = new HashMap( 1 );
 
         props.put( "reports", getReportsMenu() );
 



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]