[ http://jira.codehaus.org/browse/MNG-760?page=all ]
fabrizio giustina updated MNG-760:
----------------------------------
Attachment: MNG-760-1.diff
done some homework:
- "conclasspath" has been renamed to "classpathContainers"
- parameters are now Lists and not comma separated values, as suggested by
Trygve, and example configuration has been added to javadocs
- incorporated patch for MNG-772 and cleaned up a bit that part of code
BUT
- after converting parameters to List I couldn't find any way to set default
values using the default-value tag. Maybe should I renounce to the magic
plugin.xml generation and write it by hand? :( actually default values are set
manually and there is a todo in the code
- still no luck with the i18n component: there is nothing i18nized in maven or
mojos actually. I figured out the component Trygve talked about was the
org.codehaus.plexus.i18n.I18N, and tried adding it to dependencies
(1.0-beta-5?) and lookup it as usual (expression=${component...}) but someway
it doesn't get instantiated (and, just like for default values, I still don't
know how to set the resource bundle to use). Actually the code for messages has
been left like in the previous patch.
Maybe somebody would like to start committing this before going on?
> m2 eclipse plugin improvements (source download and attachment, customization
> of natures/builders/conclasspath, flexible project dupport) and refactoring
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-760
> URL: http://jira.codehaus.org/browse/MNG-760
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Versions: 2.0-beta-1
> Reporter: fabrizio giustina
> Fix For: 2.0-beta-1
> Attachments: MNG-760-1.diff, MNG-760.diff
>
>
> This patch adds the following to the M2 eclipse plugin:
> - downloading of source attachments and configuration in .classpath
> - customization of project builders and natures in .project (like in the m1
> plugin)
> - additional conclasspath entries in .classpath (like in the m1 plugin)
> - fix: don't add duplicate directories if main/resources directories overlap
> (like in the m1 plugin)
> - support for flexible projects (.wtpmodules file generation for utility
> modules, wars, ejbs)
> Along with these new features the plugin has been refactored, splitting the
> single big EclipseWriter class to several specific classes and all the
> messages have been externalized in a property file.
> There are still some todos in the code, which probably some M2 guru could
> look at, but anyway all the existing functionalities continue to work and
> some other tests have been added.
> Due to the refactoring the patch looks more like a complete rewrite: sorry
> for that, but adding new features without splitting the existing file was ugly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
