RE: svn commit: r365369 - in /maven/plugins/trunk/maven-surefire-plugin/src/it: ./ test1/ test1/pom.xml test1/src/ test1/src/test/ test1/src/test/java/ test1/src/test/java/SurefireTest.java

[Vincent Massol]

Hi Carlos,

> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> Sent: lundi 2 janvier 2006 17:09
> To: commits@maven.apache.org
> Subject: svn commit: r365369 - in /maven/plugins/trunk/maven-surefire-
> plugin/src/it: ./ test1/ test1/pom.xml test1/src/ test1/src/test/
> test1/src/test/java/ test1/src/test/java/SurefireTest.java
> 
> Author: carlos
> Date: Mon Jan  2 08:09:15 2006
> New Revision: 365369
> 
> URL: http://svn.apache.org/viewcvs?rev=365369&view=rev
> Log:
> Added integration test
> PR: MSUREFIRE-20

[snip]

> +public class SurefireTest extends TestCase {
> +
> +     private boolean setupCalled = false;
> +
> +     protected void setUp() {
> +             setupCalled = true;
> +     }
> +
> +     protected void tearDown() {
> +             // is there a way to tests to see if tearDown was called?
> +     }
> +
> +     public void testSetup() {
> +             assertTrue("Setup was not called", setupCalled);
> +     }
> +
> +}

Maybe you should add the following:

public SurefireTest (String name, String extraName)
{
  super(name);
}

public static Test suite()
{
    TestSuite suite = new TestSuite();
    suite.addTest(new SurefireTest("testSetup", "dummy");
    return suite;
}

This would also validate that surefire supports JUnit test suites (note the
custom onstructor which is important).

This would validate http://jira.codehaus.org/browse/MSUREFIRE-13 (which has
been closed but it didn't fix the suite problem I had).

Thanks
-Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]