Brett Porter wrote:
Have commented on there. I think outputDirectory should be writeable,
but I think that the compileSourceRoots should not. Instead, the
build-help-maven-plugin should be used to add source roots. The
limitation will be that you can't have multiple target directories
without a profile. IF this is not sufficient we need to look again at
the use case.
My concern is that anything that relies on the
project.getCompileSourceRoots will not work for anything where the
plugin configuration is altered directly. It's the same objection I have
to the changes in MRESOURCES-8.
Ok, if making compileSourceRoots writeable makes some complications in
other parts of Maven code wouldn't it be convenient to add a
CustomCompilerMojo?
It would have the the fields without default values. It could be used
whenever there is a need, and wouldn't break existing things. Since
defaults are not set, the problem with setting values of type List would
be avoided.
The rest is common for CompilerMojo and TestCompilerMojo and is already
present in AbstractCompilerMojo.
/**
* @parameter expression=false
*/
private boolean skip;
/**
* The source directories containing the source to be compiled.
* @parameter
* @required
*/
private List compileSourceRoots;
/**
* Project test classpath.
* @parameter
* @readonly
*/
private List classpathElements;
/**
* The directory where compiled classes go.
* @parameter
* @required
*/
private File outputDirectory;
/**
* A list of inclusion filters for the compiler.
* @parameter
*/
private Set testIncludes = new HashSet();
/**
* A list of exclusion filters for the compiler.
* @parameter
*/
private Set testExcludes = new HashSet();
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
