Brett Porter a écrit :
Emmanuel Venisse wrote:


Brett Porter a écrit :

Emmanuel Venisse wrote:

I think it would be good to add this method and it's easy to do. For svn, we must check if :
- .svn directory exist in directory for subversion
- CVS directory exist in directory for CVS
- .bzr directory exist in directory for bazaar
- nothing to do for file provider
- don't know for clearcase, perforce and starteam



Is that really necessary? Shouldn't it error out if you try to add something that is already added?


If you don't have .svn, CVS... directories, they aren't already added.

Emmanuel


Exactly - maybe I misunderstood but what I meant was that you don't need to check for it - if you do an addDirectory, you attempt to add the whole directory (and if something is already added, with .svn, it errors, but if none of them have .svn it is all happy).


If I understand correctly what you mean, we call addDirectory for all parents directory and we catch error for all already added directory, right?

svn doesn't fail when you try to add a directory already added, it just send a 
warning.

Emmanuel

Reply via email to