Re: Please review checkstyle plugin docs

[Maria Odea Ching]

Hi Everyone, I've already revised and applied the review comments in the plugin docs. :-) Btw, for the shared jar configuration issue in "Multimodule Configuration", I've just revised the page and mentioned the shared jar configuration issue (declaring it as an extension instead of as a plugin dependency) instead of having a separate guide for that. I did this because I think it would just have almost the same example used in "Multimodule Configuration". The staging site (http://people.apache.org/~oching/maven-checkstyle-plugin) has already been updated. Thanks, Odea Dennis Lundberg wrote: Stephen Duncan wrote: On the "Multimodule Configuration" documentation: As I just mentioned on a question on the user's list, I don't think it's correct to specify the "build-tools" dependency as a dependency of the plugin.  While this will work if you manually install the build-tools jar, it will not download it from an internal repository. It should instead be specified as build extension like in the "Using Custom Developed Chechstyle Check Modules" example.  (Also not the spelling mistake in that title: ChecHstyle). Because this is somewhat confusing, I think it should mentioned either in the "Using a Custom Checkstyle Checker Configuration" as a way of using a classpath reference, or it should be it's own guide on using a shared jar for configuration. - Stephen +1 to put the it in a guide of its own. I believe that this is a very common thing that companies and large organizations want to do. I've attached a path to MCHECKSTYLE-49 with some minor fixes. The goal descriptions are not clear to me as they are now. What is the difference between the goals? It sound like they do the same thing. Also their descriptions are not the same on the index page as on the plugin-info page. Thanks for working on this!