yes.
On 09/02/2007, at 11:14 AM, Edwin Punzalan wrote:
Brett Porter wrote:
On 09/02/2007, at 6:44 AM, Edwin Punzalan wrote:
AFAIK the reason the poms are excluded is because they're
modified by the
release process; if the check for local modifications is run
after the pom
is modified, it's impossible to do a release. So this could
probably be fixed.
That's correct, the pom is modified by the release... but the
phase which checks for local modifications is run a few phases
before that. So its safe to remove it from the ignore list.
I agree.
I'll take this a vote for #2 ?
Btw, you're testing a release with a modified pom. What if you
want to test a release with another file modified?
That's a good reason... then I guess [1] should be "if
dryRun=true, the check for local modifications need not run" ?
No, that's the point of dryRun - to see if the release will
succeed. dryRun should behave like the real thing, just not change
anything.
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]