Come, on - enforcer:enforce just sounds cool. I actually started in this direction, and the code to check both versions was nearly identical. After I thought about it for a while, I thought that these two where likely to be used very frequently together. Instead of forcing someone to bind the plugin to two executions, it made sense to combine them into a single goal. OS was different enough that it belongs separate.
If you feel strongly enough about the name, I'm not particularly tied to it...just like the way it sounds. For the version range syntax, I put some thought into this one. I decided that good or bad, someone using Maven would more likely be familiar with the current range syntax than something else. This turned out to be a major PITA because it didn't work right out of the box due to various implementation quirks. I'm open to other solutions, but I still maintain that consistency is best for the users so they don't have to learn multiple range specifications. I know that there is a proposal out there to replace the range handling in maven, and I would expect this plugin to be updated to handle new specifications as well to match maven. The OS stuff falls into the same boat, why reinvent a syntax when one already exists? -----Original Message----- From: Jason Dillon [mailto:[EMAIL PROTECTED] On Behalf Of Jason Dillon Sent: Tuesday, March 20, 2007 12:14 AM To: Maven Developers List Subject: Re: maven-enforcer-plugin Seems a wee bit odd that you have "enforcer:enforce" which handles maven version and java version, then "enforcer:os" which handles os stuff. I'd rather have enforcer:require-maven, enforcer:require- java, enforcer:require-os, * I'm also not keen on the version range muck... but I guess its more flexible that the 1.0+ and 1.0* stuff I was using. Still though the version range specification never really felt natural to me ;-) --jason On Mar 19, 2007, at 9:04 PM, Brian E. Fox wrote: > There is a new plugin that I'd like to get some feedback on, > particularly on non-windows os's and the unit tests. > > > > The maven-enforcer-plugin picks up where <prerequisites> leaves off > and > allows control over the maven, jdk and os versions of a build. > > > > This plugin was initially conceived here: > > http://www.nabble.com/Control-of-maven-using-prerequisites- > tf3231437s177 > .html#a8979318 > > And here: > > http://www.nabble.com/Why-is-prerequisites-not-inherited-- > tf3236197s177. > html#a9016296 > > > > 1.0-alpha-1-SNAPSHOT is deployed and the site is here: > http://maven.apache.org/plugins/maven-enforcer-plugin/ (just > deployed so > give it a little bit to completely update) > > > > If all goes well and no major issues are uncovered, then I think it's > ready for staging and a vote. > > > > Thanks, > > Brian > > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
