These were Nicolas' tests, but a good catch and I've made the change. BTW, the aim here is to reproduce the bugs for the first go... so if Plexus Utils is incorrectly using platform encoding then actually the test would be correct! So it may be that we revert this... should probably add an annotation around tests which are testing bugs
On 25 May 2011 09:48, Hervé BOUTEMY <[email protected]> wrote: > notice that encoding (US-ASCII or UTF-8) should be precised both when > converting String to byte[] and byte[] to String, or you're implicitely using > platform encoding which is not the best: if anybody tries to run tests on an > EBCDIC platform, they will fail (I know, this is quite rare, but that's > chicken and egg problem: it is rare because it always fail for stupid reasons, > then nobody takes care of such little things) > > Regards, > > Hervé > > Le mercredi 25 mai 2011, [email protected] a écrit : >> + assertThat( new String( new Base64().encode( "test".getBytes() ) >> ), is( "dGVzdA==" ) ); } > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
