----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/#review59533 -----------------------------------------------------------
Bad patch! Reviews applied: [26736] Failed command: ./support/apply-review.sh -n -r 26736 Error: 2014-11-02 20:49:40 URL:https://reviews.apache.org/r/26736/diff/raw/ [10915/10915] -> "26736.patch" [1] 26736.patch:52: trailing whitespace. const string& container, 26736.patch:53: trailing whitespace. const Duration& timeout, warning: 2 lines add whitespace errors. Successfully applied: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure. Ensure docker calls stop if a docker\_stop\_timeout is provided Added the flag docker\_stop\_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure. Review: https://reviews.apache.org/r/26736 src/docker/docker.cpp:490: trailing whitespace. + const string& container, src/docker/docker.cpp:491: trailing whitespace. + const Duration& timeout, Failed to commit patch - Mesos ReviewBot On Nov. 2, 2014, 8:15 p.m., Ryan Thomas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26736/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2014, 8:15 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1925 > https://issues.apache.org/jira/browse/MESOS-1925 > > > Repository: mesos-git > > > Description > ------- > > Ensure docker calls stop if a docker_stop_timeout is provided Added the flag > docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill > will be run, otherwise a docker stop with the timeout in seconds is used. A > negative value will result in a Failure. > > > Diffs > ----- > > src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89 > src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4 > src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b > src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e > src/tests/docker_containerizer_tests.cpp > 9d4ccc57f58d61c62aab5cdc79a129e987920bf6 > src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d > > Diff: https://reviews.apache.org/r/26736/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose > support/mesos-style.py > > > Thanks, > > Ryan Thomas > >
