> On Nov. 6, 2014, 6:47 a.m., Adam B wrote: > > src/tests/cram_md5_authentication_tests.cpp, line 60 > > <https://reviews.apache.org/r/27651/diff/1/?file=750935#file750935line60> > > > > Not sure why you went from 'T' to 'S' instead of 'U', but it doesn't > > bother me.
Cause I am a rebel ;) ... no, will adjust it towards the more common variant. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27651/#review60128 ----------------------------------------------------------- On Nov. 6, 2014, 12:26 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27651/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 12:26 a.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-2001 > https://issues.apache.org/jira/browse/MESOS-2001 > > > Repository: mesos-git > > > Description > ------- > > CRAMMD5Authentication tests now cover all default and modularized > authenticator/authenticatee combinations. > Also adds a test for missing credentials for the authenticatee. > > > Diffs > ----- > > src/authentication/cram_md5/authenticatee.hpp 3088a77 > src/tests/cram_md5_authentication_tests.cpp 74ea2ad > src/tests/module.hpp 7970c28 > src/tests/module.cpp 482ed22 > > Diff: https://reviews.apache.org/r/27651/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
