----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/#review60358 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/27685/#comment101721> These should be TASK_ERROR metrics. src/master/master.cpp <https://reviews.apache.org/r/27685/#comment101722> Ditto. src/tests/master_authorization_tests.cpp <https://reviews.apache.org/r/27685/#comment101723> I'm surprised this is the only test you had to fix. Don't we have tests for invalid tasks that need to be fixed? - Vinod Kone On Nov. 6, 2014, 5:29 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27685/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 5:29 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1143 > https://issues.apache.org/jira/browse/MESOS-1143 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca > src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 > src/tests/master_authorization_tests.cpp > 5ae855e59036c6cbcec15db5449620a8e5b2aa44 > > Diff: https://reviews.apache.org/r/27685/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
