> On Jan. 12, 2015, 10:33 a.m., Timothy Chen wrote: > > src/launcher/fetcher.cpp, line 288 > > <https://reviews.apache.org/r/29809/diff/1/?file=816565#file816565line288> > > > > Why would someone put a fetch URI with a NONE action?
Good point. This simplified control flow in my current (upcoming) implementation of FetcherProcess. However, it is not intuitive enough. So I will eliminate this case and rewrite the affected code portions. > On Jan. 12, 2015, 10:33 a.m., Timothy Chen wrote: > > src/slave/containerizer/fetcher.cpp, line 170 > > <https://reviews.apache.org/r/29809/diff/1/?file=816567#file816567line170> > > > > Why empty file? If there is no action that involves a cache file (action FETCH), then there still needs to be something in the protobuf/JSON for the fetcher. Alternatively, I could have only stored non-empty cache file names, but that would have complicated control flow. I will put a comment that explains this and call that a fix, OK? :-) > On Jan. 12, 2015, 10:33 a.m., Timothy Chen wrote: > > src/launcher/fetcher.cpp, lines 327-351 > > <https://reviews.apache.org/r/29809/diff/1/?file=816565#file816565line327> > > > > This block seems to be repeated 3 times, can we extract this? It is not repeated. There are differences in how downloading and extraction interact depending on which fetcher action is taken. - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29809/#review67669 ----------------------------------------------------------- On Jan. 12, 2015, 7:40 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29809/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 7:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Timothy Chen. > > > Bugs: MESOS-2069 > https://issues.apache.org/jira/browse/MESOS-2069 > > > Repository: mesos-git > > > Description > ------- > > Enhanced the fetcher program (launcher/fetcher.cpp) with fetcher cache > "actions" and an additional parameter in FetchrInfo: the cache filenames to > be used for these actions. > > > Diffs > ----- > > include/mesos/fetcher/fetcher.proto > facb87b92bf3194516f636dcc348e136af537721 > src/launcher/fetcher.cpp fed0105 > src/slave/containerizer/fetcher.hpp > 1db0eaf002c8d0eaf4e0391858e61e0912b35829 > src/slave/containerizer/fetcher.cpp > 5993670f7899233efa1e6acef4b0c7856e32f748 > > Diff: https://reviews.apache.org/r/29809/diff/ > > > Testing > ------- > > make check. > > For now it is OK if only the FETCH action works, which implements the legacy > behavior without any caching. > > The new functionality will be tested in the context of MESOS-2074. > > > Thanks, > > Bernd Mathiske > >
