@haosdent / @james: Thanks for your comments, also feel free to chime in on the Jira. Kapil just confirmed he's happy to shepherd, so we're good to go.
As for adding more "stuff" - I do agree, `Flags` is a bit on the "bare minimum" but also I wanted to avoid stuffing this method with "too much information." We can probably add more (I was thinking a pointer to the just-created instance of the 'Master' or 'Slave' class, may come in handy?) so I'll be looking forward to hear what folks have to suggest. Thanks! -- *Marco Massenzio* http://codetrips.com On Mon, Jan 11, 2016 at 11:52 AM, James Peach <[email protected]> wrote: > > > On Jan 8, 2016, at 9:43 PM, Marco Massenzio <[email protected]> > wrote: > > > > Hey folks, > > > > any takers? > > I'd really like to have an initial conversation about MESOS-4253, > > I think the concept is useful, though I'm not sure that just getting Flags > is enough. For example, I think it is reasonable for a module to store > state in the same place the agent does (ie $work_dir/meta/slaves/latest) > and the Flags would not be enough for that. I bet other people can come up > with lots of similar examples. > > > anyone > > willing to shepherd this one? > > > > Many thanks! > > > > -- > > *Marco Massenzio* > > http://codetrips.com > > > > On Mon, Jan 4, 2016 at 12:19 PM, Marco Massenzio <[email protected]> > > wrote: > > > >> Happy New Year, everyone! > >> > >> During the break, I've been playing with a toy anon module[0] mostly for > >> "learning" purposes. > >> > >> In doing so, I realized it would be useful, as a developer, to get > access > >> to even a "minimal" runtime context and filed MESOS-4253[1]. > >> (there was also a TODO from benh in the respective main.cpp of both > >> master/slave). > >> > >> I've submitted a review chain[2], which can be seen as a "proof of > >> concept," and would really be grateful if: > >> > >> - someone volunteered to be a shepherd for MESOS-4253 > >> (in particular, I'd like to discuss the approach, and especially > whether > >> just passing the Flags is sufficient, or there is something else that > may > >> be of interest); > >> > >> - someone could cast a quick critical glance on r/41760 and provide > >> feedback; > >> > >> - finally (no pun intended), I'd like to have conversation around > whether > >> we should also introduce a `finalize()` method too (again, there is a > TODO > >> about this as well). > >> (I think we should, but can be convinced otherwise) > >> > >> Thanks in advance! > >> > >> [0] https://github.com/massenz/execute-module > >> [1] https://issues.apache.org/jira/browse/MESOS-4253 > >> [2] https://reviews.apache.org/r/41760/ > >> -- > >> *Marco Massenzio* > >> http://codetrips.com > >> > >
