Is there anyone on the Tomahawk team who is willing to take ownership of this one? Right now some Tomahawk components can't be used with portlets because somebody did something bad:
HttpServletRequest request = (HttpServletRequest)facesContext.getExternalContext().getRequest(); The ExternalContext class is there so that you don't create a dependency on the servlet API. Who will sign up to fix this in Tomahawk? Thanks in advance, Stan Silvert JBoss, Inc. [EMAIL PROTECTED] callto://stansilvert > -----Original Message----- > From: Kevin Liang (JIRA) [mailto:[EMAIL PROTECTED] > Sent: Thursday, September 15, 2005 11:06 PM > To: Stan Silvert > Subject: [jira] Commented: (MYFACES-453) Tomahawk's use of > HttpServletRequest breaks JSF Portlets > > [ http://issues.apache.org/jira/browse/MYFACES- > 453?page=comments#action_12329507 ] > > Kevin Liang commented on MYFACES-453: > ------------------------------------- > > I'm trying to put the htmlEditor on Liferay 3.6 to see if it works. Then I > hit the exact problem. > We're using Liferay to develop some portal applications. JSF is definitely > the right direction to go. I'd highly appreciate if the Myfaces team could > port all components on to portlet container ASAP. Thanks. > > > Tomahawk's use of HttpServletRequest breaks JSF Portlets > > -------------------------------------------------------- > > > > Key: MYFACES-453 > > URL: http://issues.apache.org/jira/browse/MYFACES-453 > > Project: MyFaces > > Type: Bug > > Components: Tomahawk > > Versions: 1.0.9m9 > > Reporter: Stan Silvert > > Assignee: Stan Silvert > > Attachments: AddResource.239380.patch > > > > I have a report of a user who wanted to use JSCookMenu in a portlet. > This results in a ClassCastException because > org.apache.myfaces.component.html.util.AddResource assumes that the > underlying request object will be an HttpServletRequest. > > I will fix this for AddResource, but I suspect that there are other > offending classes in Tomahawk. > > For future reference, you should always use methods from > ExternalContext instead of doing > (HttpServletRequest)ExternalContext.getRequest(). > > If you MUST use features of HttpServletRequest that ExternalContext > doesn't offer then you should use the PortletUtil to make sure that you > don't break portlets. To tell if you are running in a portlet > environment, you can say: > > org.apache.myfaces.portlet.PortletUtil.isPortletRequest(FacesContext > facesContext) > > Note: calling PortletUtil does not put any dependency on the Portlet > API. > > -- > This message is automatically generated by JIRA. > - > If you think it was sent incorrectly contact one of the administrators: > http://issues.apache.org/jira/secure/Administrators.jspa > - > For more information on JIRA, see: > http://www.atlassian.com/software/jira
