[ http://issues.apache.org/jira/browse/MYFACES-737?page=all ]
Neal Haggard updated MYFACES-737:
---------------------------------
Attachment: jscookFormPatchV5.txt
Version 5 makes the changes to the Trunk, instead of branch 1_1_1. Note that I
still had to add the name of the theme onto the imageLocation,
javascriptLocation and styleLocation to allow for multiple themes to happen on
the same page. (Otherwise AddResource.java sees two theme.js and theme.css and
assumes that they're the same). If this isn't desired, AddResource needs to be
modified to take into account the baseDirectory when determining the hashCode()
and .equals() outcome.
> JSCookMenu can't be used as a child of a form, and AddResources code for
> custom themes is incomplete
> ----------------------------------------------------------------------------------------------------
>
> Key: MYFACES-737
> URL: http://issues.apache.org/jira/browse/MYFACES-737
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: 1.1.1
> Reporter: Neal Haggard
> Attachments: jscookFormPatchV4.txt, jscookFormPatchV5.txt
>
> As is stated as a known todo in HtmlJSCookMenuRenderer, the menu can not be
> the child of a form because it currently hard-codes in the form name to
> change. To fix this, the renderer must examine it's parental chain to see if
> there is a form. If so, it needs to get the clientId of the form and use
> that instead of linkDummyForm.
> The second portion of this bug is that the AddResources code, specifically,
> the code in 'addThemeSpecificResources()' is incomplete/buggy. It checks to
> see if the theme name is set to determine if it is one of the pre-defined
> ones. However, even if you specify a javascriptlocation, you still must have
> a theme name set. To fix this, instead of seeing if theme name is set (which
> it always will, as it's a required tag attribute), the renderer should see if
> javascriptLocation is NOT set, before checking theme name for one of the
> pre-defined themes. This allows those of us with custom themes that want to
> use addResources to add them dynamically, to do so by specifying the
> javascriptLocation, styleLocation and imageLocation.
> Here's a sample usage of the javascriptLocation, styleLocation, imageLocation
> as I've fixed it:
> <h:form>
> <t:jscookMenu layout="hbr" theme="ActionBar"
> javascriptLocation="/jscookmenu/"
> imageLocation="/jscookmenu/"
> styleLocation="/jscookmenu/">
> <t:navigationMenuItem id="add_attachment"
> icon="/images/addAttachment.gif" itemLabel="Add Attachment"
> action="#{noteBean.addAttachment}" />
> <t:navigationMenuItem id="delete" icon="/images/delete.gif"
> itemLabel="Delete" action="#{noteBean.delete}" />
> </t:jscookMenu>
> </h:form>
> Note that I've made my own copy of the jscookmenu scripts in /jscookmenu/,
> and my theme, ActionBar, is also under the /jscookmenu/ folder.
> As an enhancement, it would be nice if the jscookmenu allowed a generic
> 'scriptLocation' element which would be used for all three,
> javascriptLocation, imageLocation, styleLocation.
> I will attach the patch that fixes these items.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
