On 3/17/06, Dennis Byrne <[EMAIL PROTECTED]> wrote:
> Most/all of the dependencies you are talking about could be removed with 
> Shale as well, but where is the harm in impl dependecies on tomahawk *test* ? 
>  I realize they *unit* tests but I would like to see the tests use as many 
> production myfaces classes as possible, w/out a container.  This way there is 
> more coverage.

I see two dangers.

One -- you're actually limiting or biasing the test coverage for this
particular test because you're testing against a particular
implementation rather than a more abstract mock object.

Two -- by requiring impl to be a dependency for the test code, you
allow the possibility of unintentionally using impl classes in the
non-test code.   This might depend on the IDE, probably, but it's
certainly true for Eclipse.

Another observation is that end-users cannot download, build, test
Tomahawk without MyFaces impl.   Since Tomahawk is supposed to be
JSF-implementation independent, it's contrary to our stated goal to
require a specific implementation for testing or development.

Reply via email to