Can I ask a quick question? To put the test into tomahawk examples, I just: move the classes into tomahawk\examples\simple\src\main\java\org\apache\myfaces\examples\colspan (with the appropriate package names) move the jsps into tomahawk\examples\simple\src\main\webapp and update tomahawk\examples\simple\src\main\webapp\WEB-INF\examples-config.xml with my backing bean?
or is there anything else I should do? -----Original Message----- From: Mike Kienenberger (JIRA) [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 21, 2006 8:37 AM To: [EMAIL PROTECTED] Subject: [jira] Commented: (TOMAHAWK-66) add colspan (and header/footer colspan) attributes to tomahawk extended column tag [ http://issues.apache.org/jira/browse/TOMAHAWK-66?page=comments#action_123712 53 ] Mike Kienenberger commented on TOMAHAWK-66: ------------------------------------------- Can you refactor your test.zip files into tomahawk examples? That will make it a lot easier to test and maintain your changes once they are committed. > add colspan (and header/footer colspan) attributes to tomahawk > extended column tag > ---------------------------------------------------------------------- > ------------ > > Key: TOMAHAWK-66 > URL: http://issues.apache.org/jira/browse/TOMAHAWK-66 > Project: MyFaces Tomahawk > Type: Bug > Components: Columns, Column > Versions: 1.1.1 > Reporter: Lance Frohman > Priority: Minor > Attachments: HtmlColumn.java.patch, HtmlColumnTag.java.patch, > HtmlColumns.java.patch, HtmlSimpleColumn.java.patch, > HtmlTableRenderer.java.patch, column.xml.patch, test.zip, > tomahawk_column_attributes.xml.patch > > I added three new attributes to the tomahawk column tag (I didn't > change the columns tag - I don't even know if that would make sense). > The new attributes are "colspan", "headercolspan", and > "footercolspan". All the changes involve adding these attributes, > except there is also a change to HtmlTableRenderer, to implement it. > There is a new routine, "amISpannedOver", to check to see if the > column is spanned over. This replaces JIRA-426, it can be deleted. > The attached test.zip file is for testing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
