Thanks for the clarification Matt. Indeed this change can go into 1.2.4
when the 1.0.4 branch is up merged. :)
Matt Cooper (JIRA) wrote:
[ https://issues.apache.org/jira/browse/TRINIDAD-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537359 ]
Matt Cooper commented on TRINIDAD-666:
--------------------------------------
Note regarding Scott's comment about not being able to go into 1.2.3, he
mentions this just because of process. It is perfectly fine to go into
1.2.4--no patches are necessary since this will happen once committed to the
trunk and the 1.2.4 branch is created. The confusion here is that the JSF 1.1
code is still in trunk, not off into a maintenance branch and the JSF 1.2 code
is in a branch, not yet in the trunk.
Make ExternalContextUtils part of the public API
------------------------------------------------
Key: TRINIDAD-666
URL: https://issues.apache.org/jira/browse/TRINIDAD-666
Project: MyFaces Trinidad
Issue Type: Improvement
Affects Versions: 1.0.1-core, 1.0.2-core, 1.2.1-core
Reporter: Scott O'Bryan
Assignee: Matt Cooper
Fix For: 1.0.4-core
Attachments: TRINIDAD-666_1_2_3.patch, TRINIDAD-666_trunk.patch
The org.apache.myfaces.trinidadinternal.utils.ExternalContextUtils package should be promoted to the API package.
As part of this promotion, we should take a perepheral look at the "isActionRequest" method and instead return an enumeration (possibly with the ability to query capabilities). For JSR-168 and Servlet requests, the current API is satisfactory, but we will need something that could more easily be extended to support JSR-286 request types. We do not need to support these requests until the spec is final, but we should have a good upgrade path so as not to dirty the Trinidad API.
