interesting class... yes, this should most probably be refactored ;) - even though I do see some methods for Tags (e.g. setting values from tag-attributes to component-attributes).
regards, Martin On 1/18/08, Manfred Geiler <[EMAIL PROTECTED]> wrote: > Just had a look at the new commons-utils module and found the class > "TagUtils". > Please forgive me for saying it directly: This piece of code is horrible! > It seems to be a mixture of various static methods without any direct > relation to "Tags". Looks like a huge graveyard for quick and dirty > static code pieces. > Having in mind a stable API (this is what we intended with these > commons jars - right?) I must say we SHOULD get rid of this code > and/or refactor it to several separate utils classes. Each one of them > having a clear and certain scope. > > WDYT? > > --Manfred > -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
