On Thu, Mar 27, 2008 at 4:06 PM, Leonardo Uribe <[EMAIL PROTECTED]> wrote:
> In one part of the code, the hidden fields are added in this way:
>
>
> facesContext.getExternalContext().getRequestMap().put(getHiddenCommandInputsSetName(facesContext,
> form), set);
>
> but when it try to render HtmlFormRendererBase do this:
>
> Set set =
> (Set)component.getAttributes().get(HIDDEN_COMMAND_INPUTS_SET_ATTR);
>
> The idea is use one way (use request map) or another (use attributes
> (looks better at my eyes)).
>
Checking myfaces 1.1, it is using request map for this, so for remain
compatibility between 1.1 and 1.2 is best to do the same as 1.1
I have found an issue for tomahawk that says this:
>
> MYFACES-1662 : Move autoscroll feature from shared HtmlRendererUtils to
> Tomahawk
>
> Is this jira issue still valid?
>
On myfaces 1.2, autoscroll is missing but with tomahawk 1.1 and
myfaces 1.2autoscroll back to life because tomahawk override
h:commandButton and
h:commandLink renderers.
The question that remains is
Allow hidden inputs api should work on 1.2? If the answer is no, what is the
reason?
Checking h:commandButton javascript on myfaces 1.2:
input id="mainForm:j_id_jsp_1312698201_5"
name="mainForm:j_id_jsp_1312698201_5"
type="submit" value="Press me"
onclick="if(typeof window.clearFormHiddenParams_mainForm=='function'
){clearFormHiddenParams_mainForm('mainForm');}"
clearFormHiddenParamsXXXXX is rendered on page and called only if hidden
input api is active.
Another question raises:
if autoscroll should be moved to tomahawk, this api should be moved to
tomahawk instead provide this on myfaces core?
Suggestions are welcome.
regards
Leonardo Uribe
