On Thu, Jul 31, 2008 at 1:38 PM, simon <[EMAIL PROTECTED]> wrote: > Hi Leonardo, > > On Thu, 2008-07-31 at 18:27 +0000, [EMAIL PROTECTED] wrote: > > Author: lu4242 > > Date: Thu Jul 31 11:27:50 2008 > > New Revision: 681431 > > > > URL: http://svn.apache.org/viewvc?rev=681431&view=rev > > Log: > > apply checkstyle rules > > Just about these license changes: > > As I noted in an earlier email (you might have been on holiday), there > are for historical reasons two different copyright header layouts > currently in use in myfaces code. > > One has " * some text" and the other has " * some text" (one more > space). > > The approach I have taken is to publish two possible templates to check > against in the checkstyle-rules module, so that each project can use the > template that matches the majority of the existing code. That minimises > the number of files that need to be changed; a project has to be > internally consistent but can choose either layout. > > The two templates are named "myfaces-header.txt" and > "myfaces-header-spaces.txt". Personally, I prefer the one-space version > (myfaces-header.txt) as that matches what all the commons.apache.org > projects use. But I can't see any official version anywhere, so I guess > both are valid. > > Just thought I would point that out in case you weren't aware of it... >
I didn't note it. I'm just trying to create a branch for myfaces extensions validator and correct some pom.xml config to be according to myfaces code style (including apply checkstyle rules). The objective was just follow and apply the same config as buildtools/maven2-plugins, because extval in the future could need release some selected parts (like maven2-plugins). Finally I already applied the two spaces license. Thanks for the suggestions. regards Leonardo Uribe > Regards, > Simon > >
