[
https://issues.apache.org/jira/browse/MYFACES-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629378#action_12629378
]
Leonardo Uribe commented on MYFACES-1956:
-----------------------------------------
Just one minimal comment: the changes committed have tabs instead 4 spaces used
in myfaces core code.
> Minor performance improvements for org.apache.myfaces.el,
> org.apache.myfaces.context and org.apache.myfaces.util
> ----------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-1956
> URL: https://issues.apache.org/jira/browse/MYFACES-1956
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 1.2.5-SNAPSHOT
> Reporter: Bernd Bohmann
> Assignee: Bernd Bohmann
> Priority: Minor
> Fix For: 1.2.5-SNAPSHOT
>
> Attachments: MyFaces-10-requests-1.2.4.nps,
> MyFaces-10-requests-1.2.5-SNAPSHOT.nps, myfaces.el.convert-1.2.4.png,
> myfaces.el.convert-1.2.5-SNAPSHOT.png,
> myfaces.el.FacesCompositeELResolver-1.2.4.png,
> myfaces.el.FacesCompositeELResolver-1.2.5-SNAPSHOT.png
>
>
> Fixed most of the findbugs errors in the performance category and apply many
> pmd optimization rules
> Made many of the classes final.
> A method argument that is never assigned can be declared final.
> A local variable assigned only once can be declared final
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
