On Wed, Sep 10, 2008 at 9:41 AM, Simon Kitching <[EMAIL PROTECTED]>wrote:
> Leonardo Uribe schrieb: > >> Hi, >> >> I was running the needed tasks to get the 1.1.7 release of Apache >> MyFaces Tomahawk out. >> > > I have checked out the release candidate, and have just one significant > question: The tomahawk.taglib.xml has nothing in the converters section. Is > this ok? I cannot remember whether facelets needs converters explicitly > registered in the taglib file or not. > Checking this case, facelets needs the converters explicitly registered when the converter is used as a tag. There are other converters that does not have tag class (converter-for-class) but this information is on faces-config.xml. So, it is ok as is. > > As long as the converters section is not a problem, then +1 for this > release. > > I've done some basic testing with our fairly complex internal webapp, and > this release candidate seems to be working ok. > The webapp uses tomcat6.0+mojarra+facelets+orchestra. > Good to hear it. > > I've also checked checksums and sigs for the pomfile, main jar and source > jar, and they check out ok. > > I've checked the META-INF dirs of the main and source jars, and they also > look ok with the following non-release-blocking notes: > * The MANIFEST.MF holds no information about what compilation setting were > used, eg the -source and -target settings. The apache commons project puts a > whole lot more info into the MANIFEST.MF file; see inside any recent release > for details. > * The copyright date on the NOTICE.txt file is not up-to-date; it says 2007 > not 2008. > > Please note: before copying > > http://people.apache.org/~lu4242/tomahawk117/org/apache/myfaces/tomahawk<http://people.apache.org/%7Elu4242/tomahawk117/org/apache/myfaces/tomahawk> > to the replication dir, please delete all *.asc.* files. The build process > creates rubbish like > foo.asc.asc.md5 > which certainly isn't needed. > There are two options for upload to maven repository: 1. Use deploy goal over http://people.apache.org/repo/m2-ibiblio-rsync-repository/ , so the maven-metadata.xml is handled correctly 2. deploy over a local directory and then copy, destroying maven-metadata.xml We can use 1 and then go to http://people.apache.org/repo/m2-ibiblio-rsync-repository/ and delete the unnecessary files. No problem. Thanks for your suggestions Regards Leonardo Uribe > > Regards, > Simon > >
