[
https://issues.apache.org/jira/browse/TOMAHAWK-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632354#action_12632354
]
Scott O'Bryan commented on TOMAHAWK-1331:
-----------------------------------------
This is the bridge currently included with the MyFaces core 1.2, not the
JSR-301 bridge from the Apache MyFaces Portlet-Bridge project, correct? If so,
this bridge is totally unsupported (and IMO should be ripped out). The Portal
solution for 1.2 going forward should be the 301 bridge. If you are coding to
the proprietary bridge in 1.2, then you are neither testing a proper 1.1 bridge
environment OR a proper 1.2 bridge environment.
In either case. The FacesContextFactory.getFacesContext needs to be given a
PortletContext, never a portlet config. Whoever did this is violating a JSF
contract for the Factory.
> ExternalContextUtils.getRequestType() doesn't work in a portlet environment
> ---------------------------------------------------------------------------
>
> Key: TOMAHAWK-1331
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1331
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Portlet_Support
> Affects Versions: 1.1.7
> Environment: WebSphere Portal 6.0
> MyFaces 1.1.6
> Tomahawk 1.1.7
> Portals Bridges 1.0.4
> Reporter: Romain Seguy
> Attachments: TOMAHAWK-1331.log, TOMAHAWK-1331.patch
>
>
> ExternalContextUtils.getRequestType(Object config, Object request) signature
> doesn't correspond to what's used in
> TomahawkFacesContextFactory.getFacesContext(): The called method requires a
> config and a request while it's invoked using a context and a request.
> ==> This always leads to a ClassCastException at
> TomahawkFacesContextFactory.getFacesContext()#64.
> The invoked method seems to have to be fixed something like this:
> class ExternalContextUtils:
> public static final RequestType getRequestType(Object context, Object
> request) {
> if(_PORTLET_CONTEXT_CLASS != null)
> {
> if (_PORTLET_CONTEXT_CLASS.isInstance(context))
> {
> // blablabla
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
