Further clean up of ValueExpressionValueBinding and ValueBindingValueExpression
and their usage
-----------------------------------------------------------------------------------------------
Key: TRINIDAD-1255
URL: https://issues.apache.org/jira/browse/TRINIDAD-1255
Project: MyFaces Trinidad
Issue Type: Improvement
Components: Archetype
Affects Versions: 1.2.9-core, 1.2.10-core
Environment: all-
Reporter: Blake Sullivan
Priority: Minor
Attachments: JIRA-1255_1291.patch
Building on JIRA 1253-Problems with ValueBindingValueExpression and
ValueExpressionValueBinding, clean up indirect usage of
ValueExpressionValueBinding in FacesBeanImpl.addAll() to change froM:
if (toKey.getSupportsBinding())
{
setValueBindng(toKey, from.getValueBinding(fromKey));
}
to
if (toKey.getSupportsBinding())
{
setValueExpression(toKey, from.getValueExpression(fromKey));
}
Which is more efficient since we internally work with ValueExpressions.
Also, change ValueBindingValueExpression and ValueExpressionValueBinding
factory methods to unwrap, wrapped ValueBindings and ValueExpressions if passed
rather than creating new instances. This will prevent cases where previously
we could end up with a ValueExpressionValueBinding wrapping a
ValueExpressionValueBinding wrapping a ValueExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
