Thanks, Neil.

I'll add these changes. You're my hero.

Kind regards,
Antonio

On 27/02/18 10:58, Neil C Smith wrote:
On Tue, 27 Feb 2018 at 07:24 Antonio <[email protected]> wrote:

Ahh, that's the piece I was missing!


But, unfortunately possibly not all of it ...


Maybe that path is worth exploring, Neil, instead of using this ColorBox
plugin.


I think Colorbox would be a good stand in at least for now.  There are some
examples of Reveal Lightbox galleries, but I think we'd need to customize
some code, so something to look at later IMO.

The PR is good, but noticed two issues -

* It's not responsive so breaks out of the viewport - IIRC need to pass in
maxWidth and maxHeight in the colorbox netbeans.js code - I seem to have
set them both to 98% on old sites I have it on - think 100% caused issues.

* There doesn't seem to be a close button?  Maybe need to integrate one of
the (other) Colorbox themes?

An old personal site with Colorbox on (with some pictures of a NetBeans RCP
app ... really!) -
https://www.digitalprisoners.co.uk/projects/meeting-point/  It's pretty
much using stock theme 3 I think, which is the one that worked best with
mobiles and desktop.  This is an archived Drupal site that's now static, so
making sense of the setup is a little awkward!

Best wishes,

Neil



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Reply via email to