On Sat, Jul 7, 2018 at 9:48 PM, Emilian Bold <
[email protected]> wrote:

>
>
> I will also add this. We were waiting on Simon to fix the way my own patch
> was imported in his branch. Might be simpler to add Simon's patch to my
> branch and merge that.
>


Nice.

The 9.0 vc3 is going to be great.

Gj



>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 7 July 2018 10:29 PM, Geertjan Wielenga 
> <[email protected]>
> wrote:
>
> > Something else -- maybe, since you're making changes in the Welcome
> module,
> >
> > search for all hardcoded URLs, i.e., a lot of them are not hardcoded and
> >
> > are parsed from an XML file. But, if any are hardcoded, we might want to
> >
> > point those to somewhere on netbeans.apache.org instead.
> >
> > Gj
> >
> > On Sat, Jul 7, 2018 at 9:28 PM, Geertjan Wielenga <
> >
> > [email protected]> wrote:
> >
> > > That is brilliant, really fantastic and awesome. Makes such a
> difference
> > >
> > > in terms of first impression.
> > >
> > > Maybe, if it makes sense, while you're at it, include the PR about Ant
> > >
> > > version by Simon Ijskes (https://issues.apache.org/
> > >
> > > jira/browse/NETBEANS-781) unless there's a lot of work that needs to be
> > >
> > > done on his end and in that case we should include it in the next
> release.
> > >
> > > Gj
> > >
> > > On Sat, Jul 7, 2018 at 9:24 PM, Emilian Bold
> [email protected]
> > >
> > > wrote:
> > >
> > > > Hello,
> > > >
> > > > For expedience I pushed two commits for the welcome/ module (ie. the
> > > >
> > > > Start Page):
> > > >
> > > > -   https://github.com/apache/incubator-netbeans/commit/e24634c2
> > > >
> > > >     271ae3434d10d508d574aff591fac4f7 Adds an Apache Incubator logo
> and link
> > > >
> > > >     in the lower-right corner
> > > >
> > > > -   https://github.com/apache/incubator-netbeans/commit/b787422c
> > > >
> > > >     1eaec12e0f589d5ac38ad3aa24ee31d4 adds some new tab graphics
> from the
> > > >
> > > >     splash screen and a new header background.
> > > >
> > > >
> > > > The end result is: https://imgur.com/a/a2FX5vD
> > > >
> > > > Unless there is something wrong with these commits or somebody vetoes
> > > >
> > > > them, I will make another vote candidate including them.
> > > >
> > > > --emi
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>

Reply via email to